7.x has an "Add note" option, just to put any extra notes into the order, need the same simple functionality replicated in 8.x
7.x has an "Add note" option, just to put any extra notes into the order, need the same simple functionality replicated in 8.x
Comments
Comment #2
shabana.navas commentedComment #3
shabana.navas commentedI don't think Drupal Commerce 2.x currently has the ability to add order comments. We might need this patch to get that working: https://www.drupal.org/project/commerce/issues/2908196. Or am I missing something? Any thoughts?
For now, I'll submit a working version of adding a note to the order without the actual 'saving the comment to the order' part.
Comment #4
shabana.navas commentedComment #5
alexpottSo in Drupal 7 this depended on https://www.drupal.org/project/commerce_message but as per #2754623: Port to D8 this is not likely to be 8.x material - but it looks like using commerce_log might be the way to go - although we're going to build a UI if we want admin feature parity.
Comment #6
smccabe commentedPinged Bojan to get his thoughts on commerce_log, if we're going to build some UI for it, we could probably just add it right to commerce and then use in POS if needed.
Comment #7
smccabe commentedBuild in POS and we can backport to commerce
Comment #8
smccabe commentedAlex talked to me in chat and is probably going to handle this with comments attached to orders, at least we will explore that avenue.
Comment #9
sorabh.v6@smccabe Can't we add notes to order activity like we already do in commerce, just a suggestion. Please refer attached screenshot.
Comment #10
smccabe commentedThats the big debate really, Alex thinks comments might be better, and I tend to agree, since we're talking client communication so it needs a little more flexibility. But the initial idea and bojan's recommendation was commerce_log (what your screenshot shows).
What I mean by client communication, is we could also use if for people to ask questions or talk back and forth about a specific order online and it would be nice to use the same system across POS and Online
Comment #11
shabana.navas commentedUnassigning. Looks like @alexpott should be taking over from here.
Comment #12
smccabe commentedFlipping to Needs Review as this one needs to be looked over and a build path decided for it to continue.
Comment #14
smccabe commentedWow thanks d.o, it's not like an issue with a failing patch could ever need someone to review it...
Comment #15
smccabe commentedLets go with commerce_log for this, comments don't match with anything else commerce does, so I think thats being too different for not a good enough reason.
Comment #16
shabana.navas commentedWe're adding via commerce_log now.
Comment #18
sorabh.v6Comment #19
shabana.navas commentedNot sure why the heck the tests failed here. I'll have to do more investigation.
Comment #20
shabana.navas commentedTests! I'm finding more reasons to love you. I was missing the commerce_log dependency, that's why it failed.
Comment #21
sorabh.v6When I am running the test its failing and giving me error in Drupal\Tests\commerce_pos_receipt\FunctionalJavascript\PosReceiptTest:
Behat\Mink\Exception\ElementNotFoundException: Element matching xpath "//table[contains(@class, "views-view-table")]/tbody/tr[1]" not found.Drupal version 8.4.4-dev
commerce_pos branch 8.x-2.x
Comment #23
smccabe commentedTests pass on d.o, gonna assume local issue. everything worked for me, committed.
Comment #24
sorabh.v6