7.x has an "Add note" option, just to put any extra notes into the order, need the same simple functionality replicated in 8.x

Comments

smccabe created an issue. See original summary.

shabana.navas’s picture

Assigned: Unassigned » shabana.navas
shabana.navas’s picture

I don't think Drupal Commerce 2.x currently has the ability to add order comments. We might need this patch to get that working: https://www.drupal.org/project/commerce/issues/2908196. Or am I missing something? Any thoughts?

For now, I'll submit a working version of adding a note to the order without the actual 'saving the comment to the order' part.

shabana.navas’s picture

Status: Active » Needs work
StatusFileSize
new3.27 KB
alexpott’s picture

So in Drupal 7 this depended on https://www.drupal.org/project/commerce_message but as per #2754623: Port to D8 this is not likely to be 8.x material - but it looks like using commerce_log might be the way to go - although we're going to build a UI if we want admin feature parity.

smccabe’s picture

Pinged Bojan to get his thoughts on commerce_log, if we're going to build some UI for it, we could probably just add it right to commerce and then use in POS if needed.

smccabe’s picture

Build in POS and we can backport to commerce

smccabe’s picture

Alex talked to me in chat and is probably going to handle this with comments attached to orders, at least we will explore that avenue.

sorabh.v6’s picture

StatusFileSize
new36.07 KB

@smccabe Can't we add notes to order activity like we already do in commerce, just a suggestion. Please refer attached screenshot.

smccabe’s picture

Thats the big debate really, Alex thinks comments might be better, and I tend to agree, since we're talking client communication so it needs a little more flexibility. But the initial idea and bojan's recommendation was commerce_log (what your screenshot shows).

What I mean by client communication, is we could also use if for people to ask questions or talk back and forth about a specific order online and it would be nice to use the same system across POS and Online

shabana.navas’s picture

Assigned: shabana.navas » Unassigned

Unassigning. Looks like @alexpott should be taking over from here.

smccabe’s picture

Status: Needs work » Needs review

Flipping to Needs Review as this one needs to be looked over and a build path decided for it to continue.

Status: Needs review » Needs work

The last submitted patch, 4: commerce_pos-add_notes_to_order-2923195-4.patch, failed testing. View results

smccabe’s picture

Wow thanks d.o, it's not like an issue with a failing patch could ever need someone to review it...

smccabe’s picture

Lets go with commerce_log for this, comments don't match with anything else commerce does, so I think thats being too different for not a good enough reason.

shabana.navas’s picture

Status: Needs work » Needs review
StatusFileSize
new3.74 KB

We're adding via commerce_log now.

Status: Needs review » Needs work

The last submitted patch, 16: commerce_pos-add_notes_to_order-2923195-16.patch, failed testing. View results

sorabh.v6’s picture

Assigned: Unassigned » sorabh.v6
shabana.navas’s picture

Not sure why the heck the tests failed here. I'll have to do more investigation.

shabana.navas’s picture

Status: Needs work » Needs review
StatusFileSize
new4.12 KB

Tests! I'm finding more reasons to love you. I was missing the commerce_log dependency, that's why it failed.

sorabh.v6’s picture

When I am running the test its failing and giving me error in Drupal\Tests\commerce_pos_receipt\FunctionalJavascript\PosReceiptTest:

Behat\Mink\Exception\ElementNotFoundException: Element matching xpath "//table[contains(@class, "views-view-table")]/tbody/tr[1]" not found.

Drupal version 8.4.4-dev
commerce_pos branch 8.x-2.x

smccabe’s picture

Status: Needs review » Fixed

Tests pass on d.o, gonna assume local issue. everything worked for me, committed.

sorabh.v6’s picture

Assigned: sorabh.v6 » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.