Need to create a schema for auto entity label configurations as mentioned in the parent issue.
https://www.drupal.org/node/2876280

CommentFileSizeAuthor
#2 created_schema_for_auto_entity_label-2922980-2.patch710 bytesguptahemant

Comments

guptahemant created an issue. See original summary.

guptahemant’s picture

guptahemant commented
StatusFileSize
new created_schema_for_auto_entity_label-2922980-2.patch710 bytes

here is an attached patch please review.

guptahemant’s picture

guptahemant commented
Status: Active » Needs review
gg24’s picture

gg24 commented
Assigned: guptahemant » gg24
gg24’s picture

gg24 commented
Assigned: gg24 » Unassigned
piyuesh23’s picture

piyuesh23 commented

@guptahemant, Thanks for the patch. Looks good to me with a small possible improvement.

+++ b/config/schema/auto_entitylabel.schema.yml
@@ -0,0 +1,19 @@
+    status:

Shall we keep the label generation status boolean as well like the escape field? Semantically that would make more sense since the status value can be True/False.

Correct me if i am wrong assuming that status field can hold more values.

guptahemant’s picture

guptahemant commented

Hi @piyuesh23, Thanks for the review.Also status field can currently hold more than two values,
Hence set it to integer

Thanks,

piyuesh23’s picture

piyuesh23 commented
Status: Needs review » Reviewed & tested by the community

Cool. Then this is good to be merged in. Marking RTBC.

purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Patch (to be ported)

purushotam.rai’s picture

purushotam.rai commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.