Closed (fixed)
Project:
Drupal 8 Contrib Porting Tracker
Version:
8.x-0.x-dev
Component:
Module
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
11 Nov 2017 at 19:09 UTC
Updated:
22 May 2023 at 08:24 UTC
Jump to comment: Most recent
Comments
Comment #2
jwilson3Comment #3
malaynayak commentedHi @jwilson3,
I have started working on it. The code is at https://github.com/malaynayak/entity_delete_log_d8
Thanks
Comment #4
mmjvb commentedComment #5
jwilson3Comment #6
malaynayak commentedHi @jwilson3,
Can you please review the code and suggest if any further changes required.
Thanks
Comment #7
mmjvb commentedThere is no alpha or beta version available, so Status back to Needs work.
See the project details for description on using Status for these issues!
Comment #8
malaynayak commentedHi @mmjvb,
Once the code is reviewed we can go for a alpha/beta release. Correct me if I am wrong.
Comment #9
malaynayak commentedComment #10
mmjvb commentedAlready did, and again.
See the description of this project for correct usage of Status here.
This is not an issue of the module queue!
Comment #11
malaynayak commentedHi @mmjvb,
I think the module maintainer has to do this as I don't have the access for it. Lets wait.
Comment #12
mmjvb commentedUnfortunately the module maintainer is not very active. Suggest to follow the procedure for abandoned module to get attention for this module.
Comment #13
malaynayak commentedHI @mmjvb,
I have created a beta release at https://github.com/malaynayak/entity_delete_log_d8/releases/tag/v8.0-beta1. Please review.
Comment #14
jwilson3Hi @mmjvb, I'm not in a position to review this atm. but I agree with mmjvb. There is nothing requiring the maintainer of the module to track this issue, because it is not their queue.
You need to create your code as a patch against 7.x (if there is no 8.x branch created yet) and attached to #2922764: Port Entity Delete Log to Drupal 8. And then we need to take the conversation over to that issue. If you believe the maintainer will not respond, then you can open a separate ticket in the issue queue requesting to take over the project:
Read https://www.drupal.org/node/251466 for details on how to do that.
Comment #15
mmjvb commentedNo need to create a patch against D7. You can request the maintainer to assess your port and make it available on d.o.
He should be able to create the D8 branch and classify your work as dev, alpha, beta, rc or even stable. Consider making your port available as dev release on d.o. the minimum to facilitate those interested in working on a D8 version.
An active maintainer would not needed to be asked. Which is why I suggested to follow procedure for abandoned modules. Maybe you are interested to become co-maintainer, possibly only for D8 version. Maybe others are interested.
Me reviewing your port is of very little value, not being a maintainer of any module and not even a user of this module. When current maintainers don't show any interest, don't expect others to.
Despite this, I had a look at the code. Don't know whether it meets the coding standards, but don't like your use of comments. Comments should explain something that is not quite obvious from the code. Saw too many comments that have no added value.
Comment #16
jwilson3Based on feedback above, moving this back to needs work. I would also point out that your README.txt doesn't follow the typical Drupal standards.
https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
Comment #17
david.fcondezo commentedHave there been any updates on this port to D8?
Comment #18
avpadernoComment #19
avpadernoComment #20
malaynayak commentedClosing this issue as the D8 port is complete and a new release has been published.
Comment #21
avpaderno