src\Entity\OrderReport no longer has a getAmount() method. How about updating this to test that the OrderReport bundle plugin type creates the correct report?

CommentFileSizeAuthor
#2 update-order-report-generation-test-2922753-2.patch813 byteschrisrockwell

Comments

chrisrockwell created an issue. See original summary.

chrisrockwell’s picture

chrisrockwell commented
StatusFileSize
new update-order-report-generation-test-2922753-2.patch813 bytes
chrisrockwell’s picture

chrisrockwell commented
Status: Active » Needs review
Parent issue: » #2918882: Use bundle plugins for reports
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Status: Needs review » Reviewed & tested by the community

After applying patch in #15 in https://www.drupal.org/project/commerce_reports/issues/2918882, I applied patch in #2, patch looks good and its passing the test on my computer. Setting this to RTBC.

Thanks @chrisrockwell

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: update-order-report-generation-test-2922753-2.patch, failed testing. View results

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Reviewed & tested by the community

Patch passes, now

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.