commerce.time was removed in favor of datetime.time, which causes OrderReportTest.php to throw an error: 

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "commerce.time".
CommentFileSizeAuthor
#3 commerce_reports-2922750-3.patch604 bytessmccabe

Comments

chrisrockwell created an issue. See original summary.

chrisrockwell’s picture

chrisrockwell commented

I'm wondering now if this test should be removed. OrderReportGenerationTest.php covers the actual use.

smccabe’s picture

smccabe commented
Status: Active » Needs review
StatusFileSize
new commerce_reports-2922750-3.patch604 bytes

Simple patch with datetime fix, whether or not we remove this test can be figured out afterwards, but getting working tests asap is probably good.

Note, that there are other failing tests, this patch only fixes the issue mentioned here.

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Status: Needs review » Reviewed & tested by the community

Patch in #3 passed the test on my computer. Therefore setting it to RTBC.

Thanks guys.

  • mglaman committed df88603 on 8.x-1.x authored by smccabe 
    Issue #2922750 by smccabe, chrisrockwell, sorabh.v6: OrderReportTest.php...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.