Closed (fixed)
Project:
Imagick
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
10 Nov 2017 at 16:12 UTC
Updated:
11 Nov 2018 at 12:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ryross commentedAdding a comment
Comment #4
bceyssens@ryross
I applied your patch after I extended it with some settings and the option to strip metadata from images.
Thanks again!
Comment #5
joseph.olstadComment #6
joseph.olstad@bcyessens , can you please share your metadata stripping code?
Comment #7
joseph.olstadhip shot
Comment #8
bceyssens@joseph.olstad,
Here’s the patch for D8: https://cgit.drupalcode.org/imagick/commit/?id=fcbf707
Could you finish backport?
Comment #9
joseph.olstadya I'm working on it now, ignore patch 7 it's broken
Comment #10
joseph.olstadOk here's the backport of the D8 commit.
It's got config settings for strip metadata, for image optimize and the install file has a variable_del for cleanup on uninstall.
This patch works.
Comment #11
joseph.olstadComment #12
joseph.olstadminor change here , default use image optimize to TRUE instead of FALSE
strip_metadata is defaulted to FALSE
Comment #13
joseph.olstad@bceyssens thanks for the tip,
The D7 backport is complete , this would look great in a new release!
Thanks very much, great module!
Comment #14
joseph.olstadOk, this should be the last change I have to make.
A small change, moved the strip metadata down after the jpeg section as it is in D8.
also added a helpful comment for the strip metatag operation.
Comment #15
joseph.olstadI knew 13 was an unlucky number.
changed form key:
from
image_strip_metadata
to
imagick_strip_metadata
that is all
Comment #16
joseph.olstadPatch 15 is good , I think it is a keeper this time.
rats, one more change to make.
Comment #17
joseph.olstadOk patch 17 , this is the goods now.
17 is a lucky number
Comment #19
bceyssens@joseph.olstad, your latest patch is working as expected.
Thank you for your contribution!
Comment #20
joseph.olstadwoot! Thanks @bceyssens
Thanks also for your work on the D8 port, although I'm not using it (yet) it will come in handy when I do.
Great project / module.