Thanks for the module and the blog entry that brought me here.

Only thing I see missing is to have a second formatter, maybe in a submodule, to provide default image functionality for responsive images as well.

CommentFileSizeAuthor
#7 interdiff-2921908-5-7.txt1.5 KBprudloff
#7 config_default_image-2921908-7.patch3.86 KBprudloff
#5 config_default_image-responsive-2921908-5.patch3.84 KBgaëlg

Issue fork config_default_image-2921908

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

leymannx created an issue. See original summary.

svenvdv’s picture

svenvdv commented

+1 follow :)

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Active » Needs work

We don't use the responsive image module in our team, so we probably won't implement it ourselves. But if someone submits a patch and someone else reviews it, I can add it to the module.

ivnish’s picture

ivnish
he/him
commented
Status: Needs work » Active

"Needs work" for not working patches. No patch in this issue, status may be "Active"

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Version: 8.x-1.0-beta2 » 8.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new config_default_image-responsive-2921908-5.patch3.84 KB

Finally, we need it so we did it! Seems to work but not extensively tested (yet).

Status: Needs review » Needs work

The last submitted patch, 5: config_default_image-responsive-2921908-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

prudloff’s picture

prudloff commented
StatusFileSize
new config_default_image-2921908-7.patch3.86 KB
new interdiff-2921908-5-7.txt1.5 KB

I updated the patch for Drupal 10.

prudloff opened merge request !4

prudloff’s picture

prudloff commented
Status: Needs work » Needs review

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.