Split off from #2873881: [meta] Add Change Record to @deprecated for common.inc because these types of issues need to scoped by change record not file.

To determine how to complete this issue see #2873705: Add change records to all @deprecated code

Related change record: https://www.drupal.org/node/2912757

CommentFileSizeAuthor
#2 drupal-2920015-2.patch456 bytesmairi

Comments

tedbow created an issue. See original summary.

mairi’s picture

mairi commented
Status: Active » Needs review
StatusFileSize
new drupal-2920015-2.patch456 bytes

I still have the changes from our work at DrupalCon, so here is a patch to add the change record link for this one.

mairi’s picture

mairi commented

I've double-checked the change notice against the original commit that introduced the deprecation again as per the instructions on adding @deprecated records and I think the @see reference in the patch attached to comment 2 is the only one that's needed.

mairi’s picture

mairi commented

ETA - removed as duplicate comment

Status: Needs review » Needs work

The last submitted patch, 2: drupal-2920015-2.patch, failed testing. View results

mairi’s picture

mairi commented

I don't think the test failure here is caused by this patch since it only adds a comment. I'm going to try a re-test in case this was a random failure.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Reviewed & tested by the community

@mairi thanks. This looks good!

Doubled checked the commits and can confirm this is the only involved @drepecated tag in the commits.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Add Change record to @deprecated for {{ children }} in twig template » Add change record to @deprecated for drupal_render_children()

xjm credited dinarcon.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks @mairi and @tedbow! I checked in #2873881: [meta] Add Change Record to @deprecated for common.inc and looks like @mairi was also the one who worked on this change record at Vienna. Adding credit for dinarcon as a mentor as well.

Committed to 8.5.x and 8.4.x as a docs improvement, and also published the change record. Thanks!

  • xjm committed f2c1ef4 on 8.5.x 
    Issue #2920015 by mairi, tedbow, dinarcon: Add change record to @...

  • xjm committed 97f4202 on 8.4.x 
    Issue #2920015 by mairi, tedbow, dinarcon: Add change record to @...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children