Split off from #2873881: [meta] Add Change Record to @deprecated for common.inc because these types of issues need to scoped by change record not file.

To determine how to complete this issue see #2873705: Add change records to all @deprecated code

Related change record: https://www.drupal.org/node/2912696

CommentFileSizeAuthor
#5 2920014-5.patch829 bytesshashikant_chauhan
#2 drupal-2920014-2.patch487 bytesbillywardrop

Comments

tedbow created an issue. See original summary.

billywardrop’s picture

billywardrop commented
StatusFileSize
new drupal-2920014-2.patch487 bytes

I have uploaded the patch for the drupal_render_root function.

billywardrop’s picture

billywardrop commented
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Needs work

@billywardrop thanks for the patch!

The current change looks good but if you look at the change record: https://www.drupal.org/node/2912696 and

drupal_render() was also deprecated in the related issue #2346937: Implement a Renderer service; reduces drupal_render / _theme service container calls
For confirming this you can also look at the actual commit: http://cgit.drupalcode.org/drupal/commit/?id=da8ea3b

So it will also need a link to the change record.

shashikant_chauhan’s picture

shashikant_chauhan commented
Status: Needs work » Needs review
StatusFileSize
new 2920014-5.patch829 bytes

updated patch.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

@shashikant_chauhan, hi it's you again 😜, thanks for the patch!

I confirmed in #4 that drupal_render() and drupal_render_root() was the only deprecated code related to the change record.

Looks good!

xjm credited anyaabchiche.

xjm credited dinarcon.

xjm credited mairi.

xjm credited sthomps5.

xjm’s picture

xjm
she/her
Primary language English
commented

Updating credit. Last one, so hopefully no more emails for those of you that just got added to half a dozen issues. ;)

billywardrop’s picture

billywardrop commented

I was waiting on sthomps5 adding his code so he code get credit for his part of the patch. Do I not get a credit to?

  • catch committed c2346e0 on 8.5.x 
    Issue #2920014 by billywardrop, shashikant_chauhan, anyaabchiche,...

  • catch committed 6740a69 on 8.4.x 
    Issue #2920014 by billywardrop, shashikant_chauhan, anyaabchiche,...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

@billywardrop you get credited automatically when you upload a patch, so xjm didn't need to add you manually to the issue credit.

Committed/pushed to 8.5.x and cherry-picked to 8.4.x, thanks!

billywardrop’s picture

billywardrop commented

Sorry still getting used to the credit system. Thank you :)

dawehner’s picture

dawehner
Primary language German
commented
Title: Add Change record to @deprecated for Renderer service » Add Change record to @deprecated for Renderer service wrappers

A good suggestion would be to fix the title to not cause heart attacks for people :P

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children