Split off from #2873881: [meta] Add Change Record to @deprecated for common.inc because these types of issues need to scoped by change record not file.

To determine how to complete this issue see #2873705: Add change records to all @deprecated code

Related change record: https://www.drupal.org/node/2317841

CommentFileSizeAuthor
#3 2920010-3.patch892 bytesshashikant_chauhan

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Related issues: +#2873881: [meta] Add Change Record to @deprecated for common.inc
shashikant_chauhan’s picture

shashikant_chauhan commented
Status: Active » Needs review
StatusFileSize
new 2920010-3.patch892 bytes

adding patch.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

@shashikant_chauhan the patch looks great!

I have checked the CR and related issues and commits. I confirmed that drupal_clear_css_cache() and drupal_clear_js_cache() is the only code that is deprecated in the commits

xjm credited dinarcon.

xjm credited kwhite.

xjm’s picture

xjm
she/her
Primary language English
commented

Updating credit.

  • xjm committed 300d00a on 8.5.x 
    Issue #2920010 by shashikant_chauhan, tedbow, dinarcon, kwhite, xjm: Add...

  • xjm committed 8e78600 on 8.4.x 
    Issue #2920010 by shashikant_chauhan, tedbow, dinarcon, kwhite, xjm: Add...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks @shashikant_chauhan and @kwhite! I confirmed #4 (that these are the only deprecations and that they're related to the existing change record).

I also checked whether there was a @trigger_error() in the code path and there isn't. (We decided to start adding the CR to the @trigger_error() in these issues if there already is one.

Committed to 8.5.x, and backported to 8.4.x as an allowed documentation improvement. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children