Split off from #2873881: [meta] Add Change Record to @deprecated for common.inc because these types of issues need to scoped by change record not file.

To determine how to complete this issue see #2873705: Add change records to all @deprecated code

Related change record: https://www.drupal.org/node/2912661

CommentFileSizeAuthor
#4 2920005-4.patch505 bytesshashikant_chauhan

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Related issues: +#2873881: [meta] Add Change Record to @deprecated for common.inc
shashikant_chauhan’s picture

shashikant_chauhan commented
Status: Active » Needs review
StatusFileSize
new 2920005-4.patch505 bytes

Adding patch.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

@shashikant_chauhan thanks for the patch!

I have checked the CR and related issues and commit. I confirmed that valid_email_address is the only code that is deprecated in the commit.

Look great 👍! RTBC

xjm credited Janec.

Anonymous’s picture

Anonymous (not verified) commented

xjm credited davemckain.

xjm credited dinarcon.

xjm’s picture

xjm
she/her
Primary language English
commented

Updating credit

  • catch committed 8886b4d on 8.5.x 
    Issue #2920005 by shashikant_chauhan, Janec, davemckain, dinarcon: Add...

  • catch committed cd46ffd on 8.4.x 
    Issue #2920005 by shashikant_chauhan, Janec, davemckain, dinarcon: Add...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children