Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Split off from #2873881: [meta] Add Change Record to @deprecated for common.inc because these types of issues need to scoped by change record not file.
To determine how to complete this issue see #2873705: Add change records to all @deprecated code
Related change record: https://www.drupal.org/node/2448603
Comment | File | Size | Author |
---|---|---|---|
#6 | drupal-2920003-6.patch | 749 bytes | mairi |
#4 | 2920003-4.patch | 438 bytes | shashikant_chauhan |
Comments
Comment #2
tedbowComment #3
tedbowComment #4
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commentedAdding patch.
Comment #5
tedbow@shashikant_chauhan thanks for the patch
The current patch phpcs standards error "Tags must be grouped together in a doc comment."
This is because there is an existing
@see \Drupal\Core\EventSubscriber\RedirectResponseSubscriber::checkRedirectUrl()
The existing @see line should be moved right before the newly added line.
Other than that it looks good!
I have checked the CR and related issues and commits. I confirmed that
drupal_get_destination
is the only code that is deprecated in the commit.Comment #6
mairi CreditAttribution: mairi at The University of Edinburgh commentedUpdating patch to group @see tags together.
Comment #7
mairi CreditAttribution: mairi commentedComment #8
tedbow@mairi thanks looks good!
I confirmed that patch was good except for the grouping the of @see tags. The url for the CR is the same so RTBC! 🎉
Comment #11
xjmUpdating credit.
Comment #16
xjmThanks for working on these deprecations @mairi and @shashikant_chauhan!
I checked and confirmed that this is only API change from the original issue, and that the correct change record is linked in the patch.
Note that I accidentally committed this to 8.4.x only at first, so that's what the revert and recommit is about.
Comment #18
kay_v CreditAttribution: kay_v as a volunteer commentedRemoving parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children