Simplify ModerationInformation::getLatestRevisionId()

We have a few places throughout core where we've copied this block of code in order to support latest/pending revisions agnostic of content moderation. It would be awesome to see this moved into #2784201: Track the latest_revision and latest_revision_translation_affected ID in the entity data table for revisionable entity types, so we can fix all of these places in one go.

I have some more thoughts on that issue which I'll add shortly, it unblocks a lot of good cleanup and would allow these methods to either disappear or be @deprecated.

Edit: Also, this is awesome :D

I've pushed some code to the other issue for review. I think the changes in #2 make sense to keep around if that approach is accepted. I'm hoping those methods will not be as needed in the rest of core, I'm thinking contexts that need the latest revision will simply choose to load it or check isLatestRevision on the entity itself, mitigating the need to call getLatestRevisionId or getDefaultRevisionId in the first place.

There are two other methods on ModerationInformation which would become redundant however, so this issue could be highjacked to cover those.

If you think the other issue is going to be a long road or don't agree with that approach, just tell me to buzz off and I can RTBC #2, which looks like a great clean-up.

I seems a shame to block this issue on #2784201: Track the latest_revision and latest_revision_translation_affected ID in the entity data table for revisionable entity types. The patch in #2 is a nice advancement on it's own, could we push the changes in #4 to a follow up issue?

Happy to take the approach in #6, the blocker could take a while to suss out.

Awesome, might be time to RTBC #2 then?

Thanks for the reupload, looks good to me.

+1 for RTBC.

+++ b/core/modules/content_moderation/src/ModerationInformation.php
@@ -101,13 +99,12 @@ public function getLatestRevisionId($entity_type_id, $entity_id) {
   public function getDefaultRevisionId($entity_type_id, $entity_id) {

excuse my ignorance - but doesn't EntityStorageInterface::load() return the default revision? So is this method only to avoid the entity load?

Thanks

--- a/core/modules/content_moderation/src/ModerationInformation.php
+++ b/core/modules/content_moderation/src/ModerationInformation.php

@@ -84,14 +84,12 @@ public function getLatestRevision($entity_type_id, $entity_id) {
+        ->latestRevision()

@@ -101,13 +99,12 @@ public function getLatestRevisionId($entity_type_id, $entity_id) {
+        ->currentRevision()

I've been squinting at this and I can't tell how the code in HEAD is different, yet it's being changed to different things in the patch.

Ah thanks @amateescu, that's what I was missing. Also +1 for the added test coverage; that helps make it clear that the refactor is correct and safe.

Committed and pushed to 8.5.x. I also cherry-picked it to 8.4.x since it's an internal cleanup and Content Moderation is in beta anyway.

Also this marks my 1000th core commit. Hooray!