The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.This fatal error happens with PHP 5:
https://travis-ci.org/mkalkbrenner/search_api_solr/builds/290657559
I assume that the line has to look like this:
$row->{$combined_property_path}[] = $value;
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2917779-7--fix_php_5_fatal_error.patch | 1.06 KB | drunken monkey |
Comments
Comment #2
mkalkbrennerComment #3
borisson_This is the failure we're also getting for facets on travis.
Comment #4
edurenye commentedThis happens in a lot of other places in that file.
Comment #5
borisson_I think #4 does too much. I'd much prefer to see #2 committed.
Comment #6
edurenye commentedWith the #2 I couldn't have the module installed, the #4 works fine for me, maybe you are right and it's too much, but the #2 for sure is not enough.
I might keep fixing them until the installation was working, but I just proceeded to fix them all.
Comment #7
drunken monkeyI agree: #4 is too much, but #2 is too little (but also too much). The attached should be the complete fix, I think. (Interdiff compared to #2.)
For reference, the problem is this change in PHP 7: Changes to the handling of indirect variables, properties, and methods. So, we only need to change those instances where it's ambiguous, not all of them.
I actually thought we already had some issue that fixed all these problems? (As I recall, also with someone who wanted to replace every single indirect property reference to add curly braces.) Or was that in some other module?
Anyways, thanks a lot for reporting! We, of course, should definitely fix this!
Comment #9
drunken monkeyReceived Joris' blessing in IRC and test bot agrees: committed.
Thanks again everyone!
(Ah, and again forgot Joris in the commit message! >__< Sorry, was in a bit of a hurry!)