I have some submenus that are abbreviation and are all uppercase in the menu link but they appear as as capitalized on the breadcrumbs.

Example:

'PC' would appear as 'Pc' in the breadcrumbs.

Can this be changed to use the same scenario as in the menu if they are all capitalized to appeared capitalized and if they are all uppercase to appear uppercase.

Thanks.

CommentFileSizeAuthor
#19 interdiff-2917195-17-19.txt491 bytesmrinalini9
#19 easy-breadcrumb-2917195-19.patch17.15 KBmrinalini9
#17 easy-breadcrumb-2917195-17.patch16.56 KBmrinalini9
#14 wip.patch15.74 KBgreg boggs
#11 interdiff_10-11.txt1.28 KBkbrodej
#11 2917195-11.patch15.76 KBkbrodej
#10 easy-breadcrumb-capitalizer-port-2917195-10.patch15.78 KBdeaom
#5 easy-breadcrumb-capitalizer-port-2917195-5.patch15.92 KBbaikho

Comments

wolfhowling created an issue. See original summary.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Version: 8.x-1.6 » 8.x-1.x-dev
Category: Bug report » Feature request

It would be great to port the capitalizer from the Drupal 7 version. Contributions welcome!

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Title: Uppercased Menu changed to Capitalized » Capitalizer needs to be ported from Drupal 7
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Issue tags: +good-first-issue
baikho’s picture

baikho commented
Status: Active » Needs review
StatusFileSize
new easy-breadcrumb-capitalizer-port-2917195-5.patch15.92 KB

Hi there,

Here is a port for the Capitalizer options.

Just letting you know that I've put the default options from EasyBreadcrumbConstants::defaultIgnoredWords() into config & discarded the method as I thought that was sensible to do.

See attached patch.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Wow Baik Ho, this is an amazing contribution! Thank you. It will take some careful review to get it included, but I can't wait!

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

This patch needs a reroll and it's a pretty big one, so I can't get to it today. If anyone is up for it, please do!

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs review » Needs work
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Issue tags: +DrupalCampBelarus2019
deaom’s picture

deaom commented
Status: Needs work » Needs review
StatusFileSize
new easy-breadcrumb-capitalizer-port-2917195-10.patch15.78 KB

Attached is the re-rolled patch.

kbrodej’s picture

kbrodej commented
StatusFileSize
new 2917195-11.patch15.76 KB
new interdiff_10-11.txt1.28 KB

Hi reviewed the patch from #10. Applied cleanly. Found some deprecation issues with Unicode::strtoupper & Unicode::strtolower, replaced them with mb_strtoupper & mb_strtolower.

deaom’s picture

deaom commented
Status: Needs review » Reviewed & tested by the community

The corrected patch also applied cleanly, so marking it as RTBC if there is still a need for this patch as it's an old issue.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

I'm working on this patch. I've made a few edits, changing variable names from camelCase t o underscores and the like.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
StatusFileSize
new wip.patch15.74 KB

I got a bit side tracked with life. But, here's the WIP on this patch. It needs a bit more work and a reroll still.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Reviewed & tested by the community » Needs work
mrinalini9’s picture

mrinalini9 commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new easy-breadcrumb-2917195-17.patch16.56 KB

Rerolled patch #14, please review.

mrinalini9’s picture

mrinalini9 commented
Assigned: Unassigned » mrinalini9
Status: Needs review » Needs work
mrinalini9’s picture

mrinalini9 commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new easy-breadcrumb-2917195-19.patch17.15 KB
new interdiff-2917195-17-19.txt491 bytes

Please ignore patch #17, fixed #17 issue, and here is the updated patch, please review.

The last submitted patch, 17: easy-breadcrumb-2917195-17.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Thanks Mrinalini! That's super helpful!

  • Greg Boggs committed c8b0b93 on 8.x-1.x authored by baikho 
    Issue #2917195 by mrinalini9, kbrodej, Greg Boggs, DeaOm, baikho:...
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.