Problem/Motivation

Currently analytics tracking codes are not outputted, because the config key for loading these snippets is wrong (uses analytics_embed_code, but has to be analytics.embed_code).

Proposed resolution

  • Use correct config key

Remaining tasks

  • Provide a patch/PR

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#2 use_correct_config_key-2917054-2.patch818 byteshctom

Comments

hctom created an issue. See original summary.

hctom’s picture

hctom
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new use_correct_config_key-2917054-2.patch818 bytes

And here is the patch solving this issue. The corresponding PR is at: https://github.com/BurdaMagazinOrg/module-fb_instant_articles/pull/125

  • m4olivei committed 6fd287e on 8.x-2.x authored by hctom 
    Issue #2917054 by hctom: Use correct config key in...
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Fixed

Nice catch! Thanks so much! Merged to 8.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.