When we include a 'webform_entity_select' field (which supports optgroups) we receive the following error:

The website encountered an unexpected error. Please try again later.
TypeError: Argument 1 passed to Drupal\Core\Entity\EntityRepository::getTranslationFromContext() must implement interface Drupal\Core\Entity\EntityInterface, null given, called in /var/www/html/modules/contrib/webform/src/Element/WebformEntityTrait.php on line 63 in Drupal\Core\Entity\EntityRepository->getTranslationFromContext() (line 82 of core/lib/Drupal/Core/Entity/EntityRepository.php).

This seems to be related to the change in #2885715, where a guard was removed before getting the translated version.

CommentFileSizeAuthor
#4 argument_1_passed_to-2916934-4.patch770 bytesjrockowitz
#2 argument_1_passed_to-2916934-2.patch777 byteszseguin

Comments

zseguin created an issue. See original summary.

zseguin’s picture

zseguin commented
StatusFileSize
new argument_1_passed_to-2916934-2.patch777 bytes

Here's a possible fix for the issue.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new argument_1_passed_to-2916934-4.patch770 bytes

Very minor tweak.

Changed if ($option !== NULL) { to if ($option) {

  • jrockowitz committed 6707ded on 8.x-5.x 
    Issue #2916934 by zseguin, jrockowitz: Argument 1 passed to Drupal\Core\...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.