Problem/Motivation

Currently i'm trying to build a replacement view with search_api for /admin/content. The problem is that my facets are not displayed because Drupal\search_api\Plugin\search_api\display\ViewsDisplayBase::isRenderedInCurrentRequest() returns FALSE. Because getCurrentRouteMatch()->getRouteName() returns system.admin_content and not the name of the view, which overrides this route.

Proposed resolution

Extract the view parameters from the route and compare them to the plugin_definition.

Remaining tasks

Do it.

User interface changes

None.

API changes

Data model changes

CommentFileSizeAuthor
#2 2916754-2.patch913 byteschr.fritsch

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Title: Facets not shown on view » Facets not shown on view of overridden system route
StatusFileSize
new 2916754-2.patch913 bytes
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

This looks like a solid improvement. Thanks!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: General code » Plugins
Status: Reviewed & tested by the community » Fixed

I can't really say whether the change does what it should, but if you both say so, that's good enough for me.
Made a bit of code style clean-up and committed.
Thanks, both of you!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: Plugins » Views integration

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.