If the cash field has a default value in it, you expect it to clear if you start using the keypad, but instead you just add more decimal places.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | keypad-module-clear-2916646-5.patch | 3.52 KB | thejacer87 |
| #2 | keypad-module-clear-2916646-2.patch | 934 bytes | gauravjeet |
Comments
Comment #2
gauravjeet commentedcommerce_pos_keypad.jsis still not functional. The patch is for filecommerce_pos.jsComment #4
smccabe commentedThe keypad code has been consolidated into 1 setup and is no longer spread out all over the place. You should now be able to re-roll this patch for the correct js file.
Small additional note, if you press the keypad, it does clear, I think this was a side effect of the re-write. It still doesn't work if you use the keyboard though.
Comment #5
thejacer87 commentedre-rolled the patch. fixed an issue with the new code that made the keypad not actually show up for the number field. also, instead of the logic in #2 where it sets the value to the inputted key value, then appends the next keystrokes, i just select the number field so if you type anything itll clear out
Comment #6
thejacer87 commentedComment #7
sorabh.v6Reviewing it now.
Comment #8
sorabh.v6Hi,
Code is working as mentioned. Setting it to RTBC.
Thanks
Comment #9
sorabh.v6Comment #11
sorabh.v6Wrong patch uploaded and its checking that patch which it should not. :D
Comment #13
smccabe commentedWorks correctly for me, both issues fixed. The code that limits the field types and required fixing in this patch seems inflexible as it caused the keypad to not display and could cause problems in the future. I didn't have a good solution though so I just added a comment explaining for now.