If the cash field has a default value in it, you expect it to clear if you start using the keypad, but instead you just add more decimal places.

Comments

smccabe created an issue. See original summary.

gauravjeet’s picture

Status: Active » Needs review
StatusFileSize
new934 bytes

commerce_pos_keypad.js is still not functional. The patch is for file commerce_pos.js

Status: Needs review » Needs work

The last submitted patch, 2: keypad-module-clear-2916646-2.patch, failed testing. View results

smccabe’s picture

The keypad code has been consolidated into 1 setup and is no longer spread out all over the place. You should now be able to re-roll this patch for the correct js file.

Small additional note, if you press the keypad, it does clear, I think this was a side effect of the re-write. It still doesn't work if you use the keyboard though.

thejacer87’s picture

StatusFileSize
new3.52 KB

re-rolled the patch. fixed an issue with the new code that made the keypad not actually show up for the number field. also, instead of the logic in #2 where it sets the value to the inputted key value, then appends the next keystrokes, i just select the number field so if you type anything itll clear out

thejacer87’s picture

Status: Needs work » Needs review
sorabh.v6’s picture

Assigned: Unassigned » sorabh.v6

Reviewing it now.

sorabh.v6’s picture

Assigned: sorabh.v6 » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new5.33 KB

Hi,

Code is working as mentioned. Setting it to RTBC.

Thanks

sorabh.v6’s picture

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: keypad-module-clear-2916646-8.patch, failed testing. View results

sorabh.v6’s picture

Status: Needs work » Reviewed & tested by the community

Wrong patch uploaded and its checking that patch which it should not. :D

  • smccabe committed 3828ef8 on 8.x-2.x authored by thejacer87
    Issue #2916646 by sorabh.v6, thejacer87, gauravjeet: Keypad module doesn...
smccabe’s picture

Status: Reviewed & tested by the community » Fixed

Works correctly for me, both issues fixed. The code that limits the field types and required fixing in this patch seems inflexible as it caused the keypad to not display and could cause problems in the future. I didn't have a good solution though so I just added a comment explaining for now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.