Allow the menu link titles at core.menu.static_menu_link_overrides.yml to be overriden

This is simple, powerful, and has tests!

The only reason i can think this wasn't included to start with might be internationalization support? But if you don't override, you don't lose whatever support the module might or might not be providing anyway.

+++ b/core/config/schema/core.menu.schema.yml
@@ -9,6 +9,9 @@ core.menu.static_menu_link_overrides:
+            type: string

I think this needs to be translatable - so should be of type label as that will enable config translation.

Also we need an upgrade path for existing configuration.

This patch also breaks existing translations. If you:

1. Install standard without the patch applied
2. Enable config_transaltion
3. Add Arabic
4. View frontpage
5. The contact link in the footer is translated into arabic

But if you:

1. Install standard with the patch applied
2. Enable config_transaltion
3. Add Arabic
4. View frontpage
5. The contact link in the footer is not translated

1. +++ b/core/modules/system/system.install
   @@ -2042,3 +2042,28 @@ function system_update_8403() {
   +/**
   + * Add the titles into the static_menu_link_overrides config.
   + */
   +function system_update_8501() {
   

   Move this to be a post update - see core/modules/system/system.post_update.php. You might be using API you can't rely on in a hook_update_N

2. +++ b/core/modules/system/system.install
   @@ -2042,3 +2042,28 @@ function system_update_8403() {
   +  $menuLinkManager = \Drupal::service('plugin.manager.menu.link');
   +  $definition = $menuLinkManager->getDefinitions();
   +
   +  /** @var Drupal\Core\Menu\StaticMenuLinkOverrides $staticOverrides */
   +  $staticOverrides = \Drupal::service('menu_link.static.overrides');
   +
   +  foreach ($definition as $plugin_id => $menu_link) {
   

   We could do less looping by doing something like:

       $overrides = $staticOverrides->loadMultipleOverrides(array_keys($definitions));
       foreach ($overrides as $id => $changes) {
   

   And no need for a continue too :)

Bump. I just spent 1/2 an hour trying to figure out why I couldn't delete the home link. Disabling it is OK but not clean. I'm all for making it deletable.

Wishfully hoping the testbot might have changed its mind...

Re-roll of patch #19 against 9.2.x-dev

Can you re-roll the patch for Drupal 8?

Thanks!

For now, I ended up using the hook_toolbar_alter() function

/**
 * Implements hook_toolbar_alter().
 */
function MYMODULE_toolbar_alter(&$items) {
  
  // Override titles of top level items
  $items['workbench']['tab']['#title'] = "Admin Workbench";
  $items['administration']['tab']['#title'] = "Manage Drupal";

}

See https://www.drupal.org/project/toolbar_menu/issues/2949053#comment-13998889

Code looks good, update path is in place, tests are passing.

Manual testing went good. Tested on Drupal 9.1.4.

Patch #33, Failed to apply. needs re-roll.

Reroll the patch for 9.2.x.

Fixed syntax error.

The re-rolled and fixed patch of #42 is RTBC as per #37 and my own and others testing and use in production.

This needs to apply-able to 10.0.x and 9.4.x - as a task those are the only branches open where this can land but there are conflicts in core/lib/Drupal/Core/Menu/StaticMenuLinkOverridesInterface.php and core/tests/Drupal/Tests/Core/Menu/StaticMenuLinkOverridesTest.php

I have updated the patch for D9.4, Please review.
Patch #42, is no longer applies to D9, so not able to generate interdiff for same.

To override the menu title of Taxonomy Menu #3261003: Allow override the taxonomy menu link titles in at core.menu.static_menu_link_overrides.yml

Should this be a bug report? It's a little silly that the title isn't editable.

Returning to RTBC and triggered tests to see if any issues with 10.x and 9.5.x

This needs a patch that applies to 10.0.x.

The issue summary should explain the resolution here, adding tag for an is update. A fail patch would be helpful as well.

Way back in #13 it was reported that the patch changed the contact link in the footer of a standard install. Perhaps I missed it but I don't see confirmation that that has been fixed.

Re-roll of #49 against 10.1.x.

I have attached patch for 11.x

#54 mentions an issue summary update which is still needed.

Have not reviewed or tested.

Adding a reroll for 10.3

Rerolled for 10.3.1

I've created a MR against 11.x and updated the summary to explain the resolution

MR appears to have pipeline issues

With regards to the post_update hook this something may want to use a ConfigImporter class to run in batches?

Post update hook will need test coverage too

Thanks!

Fixed PHPSTAN and PHPCS. Pipeline has failing unit test(s).