Seems #2903407: Use #optional for containers where appropriate broke our AJAX functionality (displaying a backend/datasource/tracker form when that plugin is selected), since that needed the empty container to be present. We'll need to revert most of that change.

CommentFileSizeAuthor
#2 2916208-2--fix_plugin_form_ajax--tests_only.patch5.75 KBdrunken monkey
#2 2916208-2--fix_plugin_form_ajax.patch7.4 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2916208-2--fix_plugin_form_ajax.patch7.4 KB
new 2916208-2--fix_plugin_form_ajax--tests_only.patch5.75 KB

This should do it – and adds a test for all that functionality.

Status: Needs review » Needs work

The last submitted patch, 2: 2916208-2--fix_plugin_form_ajax--tests_only.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review

I think we can live with the "tests only" patch failing …

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Yes, looks great.

  • drunken monkey committed e7e3577 on 8.x-1.x 
    Issue #2916208 by drunken monkey: Fixed AJAX display of plugin forms.
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Good, thanks for reviewing!
Committed.
(Sorry, forgot to credit you in the commit message!)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.