Since the 8.4 release, following the work on #2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button, there's no longer a 'publish' button in node edit forms.
Rabbithole still references the old button in rh_node/src/Plugin/RabbitHoleEntityPlugin/Node.php, and by doing so triggers a warning when an user displays the node edit form.

class Node extends RabbitHoleEntityPluginBase {
  /**
   * {@inheritdoc}
   */
  public function getFormSubmitHandlerAttachLocations() {
    return [
      ['actions', 'submit', '#submit'],
      ['actions', 'publish', '#submit'],
    ];
  }
}

I'm currently working on a patch.

Comments

Nishruu created an issue. See original summary.

nishruu’s picture

Issue summary: View changes
nishruu’s picture

Issue summary: View changes
nishruu’s picture

mallezie’s picture

Status: Active » Needs review

Tested this, patch looks good, and works as advertised.

Setting to needs review to let tests kick in.

mallezie’s picture

Status: Needs review » Reviewed & tested by the community

Seems there are no tests ;-) although not run automatically.

Applied it manually, works as advertised.

nishruu’s picture

I'm still new to D8, but I don't know what kind of test would I have to create to test that the warning doesn't appear (if it's supposed to test that part ?). Can you enlighten me for my future patches ?

mallezie’s picture

@nishree. That was not what i meant here. When you upload a patch and set the status to needs review it turns it's tests through drupal.org if that is enabled for the project. (Which is not the case here)

dylan donkersgoed’s picture

Status: Reviewed & tested by the community » Fixed

Looks good, merging this in to dev. Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.