Style error information

https://eslint.org/docs/rules/no-lonely-if

Remark

- Code refactoring. Review it carefully :)

How to Review

## 1. Apply Patch
## 2. Review Code Changes
## 3. Confirm no Code Standard Errors
yarn & yarn lint:core-js-passing
## 4.1 If `NO` errors, mark the issue as `Reviewed & tested by the community` (Don't be shy, we're all friendly)
## 4.2 If `HAS` errors, fix it and upload a new patch (Just do it and you can!!!)

Background

- #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core

- We adapted the airbnb coding standard (#2815077: Adopt airbnb javascript style guide v14.1 as new baseline javascript coding standards for Drupal 8 core and contrib), but we are not fully compliant to it yet.

More Information

- Using ES6 in Core
https://www.drupal.org/node/2815083

- To find JS code standard errors stats
yarn & yarn lint:core-js-stats

Valuable Follow-up

- N/A

CommentFileSizeAuthor
eslint-no-lonely-if.patch2.89 KBdroplet

Comments

droplet created an issue. See original summary.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +JavaScript clean-up

apply and fixes the errors. No logic change.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes

Status: Reviewed & tested by the community » Needs work

The last submitted patch, eslint-no-lonely-if.patch, failed testing. View results

droplet’s picture

droplet commented
Status: Needs work » Reviewed & tested by the community

random errors. back to #2 status

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 844b6d3 and pushed to 8.5.x. Thanks!

  • alexpott committed 844b6d3 on 8.5.x 
    Issue #2914716 by droplet: JS codestyle: no-lonely-if

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.