Problem/Motivation

minimal_install() updates two configuration files as part of the installation. This is not necessary. The ConfigInstaller will prefer config in the profile's config/install directory.

In #2788777: Allow a site-specific profile to be installed from existing config we're trying to allow sites to be completely installed from configuration. Whilst module's implementations of hook_install() have to be compatible with being installed via the ConfigImporter at the moment there is no requirement for install profile's implementations to be because they will always be installed prior to running an import.

Proposed resolution

  • Remove minimal_install()
  • Create necessary config files in minimal/config/install
  • Add tests to ensure configuration is correct

Remaining tasks

User interface changes

None

API changes

None - a hook implementation is not API.

Data model changes

None

CommentFileSizeAuthor
#2 2914379-2.patch2.98 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2914379-2.patch2.98 KB

Here's a patch

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Related issues: +#2788777: Allow a site-specific profile to be installed from existing config
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

This looks solid.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Remove minimal_install() » Remove minimal_install(), ship with default configuration instead

  • Gábor Hojtsy committed 8dc5009 on 8.5.x 
    Issue #2914379 by alexpott: Remove minimal_install(), ship with default...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Makes total sense. This would be best practice also. Committed to 8.5.x. While I don't think this would break anything in 8.4.x, not 100% sure this is eligible for backport. (I *think* it may be since it only ever affects new sites).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cilefen’s picture

cilefen commented

#3000677: Fatal error after upgrade to 8.6x [due to regression in extension system]