Follow-up to #2896229: move date handling to a processor, so date facets can use existing widgets for consistency. So that the settings can be changed, granularity can be accessed, from the config in the same way when constructing the query. Plus you could use other widgets.
Task: move granularity logic - like the date logic - to a processor, and possibly remove the numeric granular widget completely.
Also provide an upgrade path - just like in the date processor.
Let's also use this task to add tests for the granularity.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | move_numeric-2913329-11.patch | 13.77 KB | borisson_ |
Comments
Comment #2
borisson_Comment #3
borisson_I ran all kernel and unit tests locally and had to fix one kernel test. We don't seem to have any functional tests for this though, making it somewhat less awesome to do this change.
No upgrade path yet.
Comment #4
borisson_Needs config schema.
Comment #5
borisson_Comment #6
borisson_Adds an integration test as well.
Comment #8
borisson_The integration test should now be green, it is locally. The unit test is still not passing but I have to leave. Would love to get input on the direction though.
Comment #10
borisson_Comment #12
borisson_Crediting d.novikov for his work in #2920982: Disallow '0' granularity when using "Granular numeric list" widget..
Integrated that in here + added form validation by setting the minimum value as an attribute.
Comment #14
borisson_Failed because of #2922302: Fix deprecated usage of twig's 'replace' filter
Comment #15
borisson_Going to commit this later today.
Comment #17
borisson_Committed, thanks!