It seems that the ability to enable or disable a list is redundant, or at least with the subscription module at least, because CampaignMonitor->getLists() doesn't check if the lists are enabled and returns all lists in the cache.

Aside from adding an enable check I would recommend adding lists as disabled by default.

Main issues with the current default:

  • Typically any large organisation will have quite a few lists, and often some crud
  • Currently a list added in CM will be automatically available in a user select subscribe form
CommentFileSizeAuthor
#11 campaignmonitor-subscribe-lists-enabled-check-2911962-11.patch1.17 KBmrinalini9
#4 campaignmonitor-subscribe-lists-enabled-check-2911962-4.patch1.23 KBjohnpitcairn

Comments

dkre created an issue. See original summary.

NewZeal’s picture

NewZeal commented

Thanks for the heads up. If you can supply a patch that would be great.

johnpitcairn’s picture

johnpitcairn commented
Version: 8.x-1.0-beta3 » 8.x-1.x-dev
johnpitcairn’s picture

johnpitcairn commented
Category: Task » Bug report
StatusFileSize
new campaignmonitor-subscribe-lists-enabled-check-2911962-4.patch1.23 KB

Here's a patch that adds a simple check so that only enabled lists are available in the subscribe form block configuration and user-facing form.

It does not address the problem of new lists being enabled by default, which I agree needs to be addressed.

And frankly, this is a bug.

johnpitcairn’s picture

johnpitcairn commented
Related issues: +#2784253: Subscribe form doesn't check for default selected custom fields

Possibly related: #2784253: Subscribe form doesn't check for default selected custom fields

NewZeal’s picture

NewZeal commented
Status: Active » Fixed

Implemented in 8.x-2.0-alpha1

johnpitcairn’s picture

johnpitcairn commented

Can we also commit the patch to 8.x-1.x?

johnpitcairn’s picture

johnpitcairn commented
Status: Fixed » Patch (to be ported)
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Patch (to be ported) » Needs work

No longer applicable to version 2.x. Please update.

mrinalini9’s picture

mrinalini9 commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new campaignmonitor-subscribe-lists-enabled-check-2911962-11.patch1.17 KB

I have rerolled patch for 8.x-2.x, please review.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs review » Reviewed & tested by the community

  • VladimirAus committed c9b1568 on 8.x-2.x authored by mrinalini9 
    Issue #2911962 by John Pitcairn, mrinalini9, VladimirAus: List disable/...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.