Follow-up to #2826403: Plan for Feeds 7.x-2.0-beta4 release

Issues of interest:

  1. Cron issues
    There are a lot of reports about imports that do not work during cron. To add more insight to the problem, a feature to see the next import time was added to 7.x-2.0-beta4. Perhaps this already fixes a part of the cron issues. We hope to fix a few other cron issues by running the imports during cron as either user 1 or the user who created the feed node.
    #2541944: Switch to feed author or user 1 during imports (taxonomy mapping does not work with cron)
    #1995728: [META] Cron import not working on 7.x-2.0-alpha8 and later
  2. Validation
    Feeds 7.x-2.0-beta4 has become stricter on validating imports to minimize SQL errors on imports. It also validates importers themselves. We want to extend validation by no longer allow attaching two importers to the same content type and by locking some settings when there is already imported data.
    #2474589: Changing processor wipes mappings with no warning
    #2640108: Display an error message when attaching an importer to a content type that is already in use by an other importer
  3. Aborted CSV import
    There is one big issue left related to imports that need multiple cron runs to complete: a source to import from is stored as a temporary file, which is removed after 6 hours. If the import hasn't been completed by then, the import will be aborted and the importer will be stuck in a locked state.
    #1029102: Importing Large CSV document (downloaded and processed in the background)
  4. Other issues
    #2922268: Standalone import works, cron import has field validation errors
    #2918840: Field validation errors in item: only validate mapped fields
    #2911711: FeedsHTTPCache class could not be found: 7.x-2.0-beta4 database update can only run if Feeds is enabled
  5. PHP 7.3 compatible
    #3013743: PHP 7.3: 'continue' used within 'switch' control structure

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Parent issue: » #1301678: Release Path and Roadmap for Feeds 7.x-2.0
irinaz’s picture

irinaz commented

We have been using Feeds 7 as stable product, we might as well release this version for 7 as non-beta final version and have in showing up in green color :))
@StanfordDrupalCamp

megachriz’s picture

megachriz
Primary language Dutch
commented
Issue summary: View changes

@irinaz
Yes, if all mentioned issues above are fixed, we could issue a RC as well. The RC can the follow up with a "final" version a month later if nothing critical comes up. Beta4 - compared to beta3 - did introduce some disruptive changes for example. I'm still trying to find time to fix these. See #2922268: Standalone import works, cron import has field validation errors, #2918840: Field validation errors in item: only validate mapped fields and #2911711: FeedsHTTPCache class could not be found: 7.x-2.0-beta4 database update can only run if Feeds is enabled.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Priority: Normal » Critical

We updated feeds just recently and then realized that we had bugs that were fixed a long time ago like #2918931: Basic Authorization failed with 401 in http_request.inc. Please create regular releases so that users do not run into the same bugs again.

Bumping this to critical since the current 7.x-2.0-beta4 release breaks older module installations.

megachriz’s picture

megachriz
Primary language Dutch
commented

@klausi
I wasn't aware that anything fixed in dev would be critical, so thanks for letting me know. Reason for not releasing beta5 yet is that the dev version doesn't fix all issues introduced by beta4: mainly the field validation issues. So therefore I didn't see any benefit in making a new release yet. If I remember well, the dev version also contains half of the fix for an other bug, so that left me to think releasing beta5 now would fix almost nothing compared to beta4.

It appears that all of my time I have for open source, goes to the D8 version for which several things are also considered quite "critical" to work on. I have been working on porting the Feeds Tamper Rewrite plugin to D8 and I hope to find time to review/complement the multilingual issue for the D8 version of Feeds. And with a team I'm working on writing a Feeds-like UI for Migrate: Feeds Migrate. So that leaves zero time for me to spend on the D7 version.

So not sure what to do here. I could try to plan in some time for the D7 version, but it seems unlikely I will come to that soon. I consider the points listed above more critical than this.

martin_klima’s picture

martin_klima
he/his
Primary language Czech
commented

I think it would be nice to create revisions every time something is fixed. We don't have to use so many patches then.

megachriz’s picture

megachriz
Primary language Dutch
commented

#2541944: Switch to feed author or user 1 during imports (taxonomy mapping does not work with cron) could in theory introduce new regressions. There actually already has been one which was fixed in #2943953: Fatal error "No more accounts to revert to." when trying to unlock a feed.

So it would be great if anyone testing the dev version would report here if the dev version didn't introduce new regressions like the one above. Then perhaps I can create a new release even if it doesn't fix the regressions introduced by beta4.

wylbur’s picture

wylbur commented
Issue summary: View changes

Just adding PHP 7.3 compatibility issue to list of items to be addressed in new release.

megachriz’s picture

megachriz
Primary language Dutch
commented

@wilbur
Thanks. It would also be good to open an issue to fix the branch tests. These are failing since the latest release of the Link module.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Reviewed & tested by the community

@MegaChriz, I think we are good to make another beta release, there is a good chunk of commits and it helps with PHP 7.4/7.3 progress.

We can roll the items that are unfinished into the next release. I'll probably do this tomorrow, but want to get a 👍👎 from you if you have any reservations?

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Feeds 7.x-2.0-beta5 has been released, thanks to @joelpittet fixing and committing issues for PHP 7.2+ support.

@joelpittet
I don't remember if the issues I listed here are ready for commit. It could be that I left them for doing a self-review later but it can also be that they need additional test coverage. It would be wise to go through the code changes carefully. See if you can spot anything that would benefit from having additional automated tests.

megachriz’s picture

megachriz
Primary language Dutch
commented

Follow-up: #3164943: Plan for Feeds 7.x-2.0-beta6 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.