Problem/Motivation

When you have an ajax link within dropbuttons, the throbber jumps to the next line

This was found out during #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait, and it was decided to split that part of the patch into its own issue.

See the bug:
bug gif

Proposed resolution

Fix it in dropbutton.component.css

Remaining tasks

Do it

User interface changes

None (UI bug prevented)

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2909882-2.patch793 bytesManuel Garcia
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

Manuel Garcia created an issue. See original summary.

Manuel Garcia’s picture

Status: Active » Needs review
FileSize
793 bytes

Attaching patch split off of #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait
This is how the throbbers looks with the patch:
bug fixed

timmillwood’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Workflow Initiative

I think this is a hard one to test, and until #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait lands I don't think there are any throbblers on drop buttons in core, but it fixes the issue.

xjm’s picture

Thanks @timmillwood!

I have actually seen this before somewhere in core, not sure where. Probably the Views UI or something. In any case, tagging for the frontend committers.

timmillwood’s picture

Thanks to @Manuel Garcia!

Views uses a full-screen throbber, as added in #2207695: Expand the throbber API to include a 'full screen' option, from what I can see. Although we'll soon have somewhere in core doing it, when #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait gets in. ;)

yoroy’s picture

I tested this on simplytest, using this patch and the one in #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait. The throbber stays on the same line now, so looks good to me!

yoroy’s picture

  • lauriii committed e9b7716 on 8.5.x
    Issue #2909882 by Manuel Garcia, yoroy: Throbbers showing within...

lauriii credited lauriii.

lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Removed on the commit the px from the 0 value.

Committed 0540b0e and pushed to 8.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

idebr’s picture

Issue tags: +CSS

This change causes the ajax progress content to be displayed on top of other content. This becomes very apparent when working with the Paragraphs module:

I suggest this change is reverted until we have determined a solution that works for all ajax progress indicators.

I have also filed a bug report at #2935593: Ajax progress throbber displays on top of other content