Add a config to disable the hoverintent functionality

Hi,

The initial patch had this option, but we want to keep Admin Toolbar plug-and-play. This functionnality seems crucial for me as when you loose focus you must start again and we had lots of complaints about it.

What disturbs you ? Maybe the delay could be adapted if it's too long ?

Regards,

Please test against the dev version. Hover delay has been reduced.

I agree on the long delay setting.

In dev version, we reduced the delay to 250 instead of 500. Seems better to me.

I test it and it works.

Thanks all for the work, at least we have the option now to use it or not :-)

Hello,

I think we shouldn't keep a config page only for that option. What we should do is disable the hover delay on mouse in and keep only on mouse out. I think that would fix the issue for everybody cleanly.

Hi eme in order to try to release a new module version now that we have #2917704: Add Administration links access filter module as Admin Toolbar submodule what do you think that we need to made in this issue?

Well reverting the commit (manually, I'm tired to use a tool to fix conflicts now) as discuted by mail with eme and romainj is better to keep this plug and play, so @eme as you says JS is all yours :-)

@adriancid I agree with you that such modules should be plug-and-play ones, but till this issue is fixed can we use the patch as a temporarily solution?

I needed the old patch in one of my projects so I re-rolled it to the latest dev version so I can include it in composer and my profile make files.

Well, maybe we could just put the hoverIntent.js as a separate library so that you can in your theme or in a module remove it easily with no patch ?

For now we had more complaints about the subelements disappearing that the hover being too slow (now that we've but 250ms).

Casting another vote for having a config page to toggle this on and off. The module works great as a plug and play, and having a config page with one option won't harm that, especially if hover intent is turned on by default, and has to be disabled.

That wouldn't be the end of the world for the people who don't like it, and wouldn't bother people who need it either.

Casting another vote for having a config page to toggle this on and off.

After reading through this issue thread it appears as though the status should be needs work. Additionally, the issue should be on 8.x-2.x-dev.

IMHO I think that having a PHP settings to enable/disable such a feature isn't that great. That's basically a UI feature so it should not require to toggle a PHP settings.
I think that we should postpone this issue for now.

As https://www.drupal.org/project/admin_toolbar/issues/3094835 has been commited we could add this option. I will have a look soon and provide a patch.

I'll work on it.

Patch #30 works for me.

So moving to RTBC per comment #31.
Thanks!

Commited to latest dev version.