The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
Here's the class header:
/**
* Represents a configuration of an index that was not yet permanently saved.
*
* Proxy code created with:
* php ./core/scripts/generate-proxy-class.php 'Drupal\search_api\IndexInterface' modules/search_api/src/
*/
class UnsavedIndexConfiguration implements IndexInterface, UnsavedConfigurationInterface {
But this class doesn't look as if it has been generated with the proxy script. Probably it has been copied from somewhere?
Proposed resolution
Remove the text. Allow coding standards on this file.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2908440-2.patch | 702 bytes | claudiu.cristea |
Comments
Comment #2
claudiu.cristeaPatch.
Comment #3
claudiu.cristeaOuch!
Comment #4
claudiu.cristeaBTW, where is this interface used? ;)EDIT: Ignore this question.Comment #5
borisson_You're right, if I run the command again, it completely changes.
$ php ./core/scripts/generate-proxy-class.php 'Drupal\search_api\IndexInterface' modules/search_api/src/Comment #8
drunken monkeyHm, well, if it was automatically generated, we at least definitely kept working on it, improving coding standards, adding/changing methods according to the interface, etc. But it's also possible the comment was wrong to begin with. A moot point in any case, you're right, neither that comment nor the
@codingStandardsIgnoreFileserve any purpose now. So, thanks a lot for the patch! Committed.(Weird, could have sworn we already had an issue for that … Or did we just discuss it in one of the coding standards issues?)
Comment #9
drunken monkeyWhat?!? No, I didn't!
Comment #10
borisson_#9, that's a new thing - the committer automatically gets credit on the issue after closing it. You'll see that popping up more frequently in issues.
Comment #11
drunken monkeyAh, OK. Thanks for the info! (Just read about it in the "What's new" post, too.)
Then I guess I should be more generous with those credits in the future in general. (Unfair if I get a credit for a cursory review when others don't get one.)