When i use "All but external scripts" option for "Deferred JavaScript Execution: Add The defer Tag To All Script Tags"
in system with Adminimal Administration Menu my "admin" "display experience" it seems wrong:

- Sometimes the admin menu is not displayed.
- The Fieldsets are not collapsible - are broken
- Fieldset Tabs (vertical/horizantal) - broken

I don't know if this is an "Adminimal Administration Menu" or advagg issue, but i thought to ask here first (more active).
Thank you

p.s. i didn't notice any js error messages for this issue.

CommentFileSizeAuthor
#12 advagg-2907586-11-hotfix-slicknav.patch2.72 KBmikeytown2
#8 advagg-2907586-8-hotfix-slicknav.patch2.46 KBmikeytown2

Comments

vasike created an issue. See original summary.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

Is is different from this issue? #2902776: New version of Advagg breaks adminimal admin menu

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike at Centarro commented

This is a new/other issue. I tried with latest version which includes this fix.
The issue it's for the latest dev version.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

If there are no JS errors then it could be something else. I'd undo this patch #2902776-8: New version of Advagg breaks adminimal admin menu and apply this patch #2407007-20: Uncaught TypeError when using with Media. I set admin menu to run last due to some random errors I was getting.

Other things not working should indicate a JS error; maybe one of these times it will display one in the console? If you can list the steps needed to reproduce the error with a fresh install that would be good.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

@vasike
Did you try the steps in #4; Undo patch and apply patch for Adminimal Administration Menu?

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike at Centarro commented

@mikeytown2
i remember i tried with no success. before opening this issue

It seems i get an error in console, maybe it helps
Uncaught TypeError: Cannot read property 'behaviors' of undefined
And the code :
... ;if(o instanceof n&&typeof o[t]==='function'){i=o[t].apply(o,Array.prototype.slice.call(s,1))}});return i!==undefined?i:this}}}($jQueryAdminimal,document,window));(function(e){Drupal.admin.behaviors.responsivemenu=function(t,n,i){e('#admin-menu-menu-responsive').slicknav({label:'Menu',prependTo:'body',closedSymbol:'<i ...

i hope i copied right from the big js.

Maybe this is an Adminimal Administration Menu issue after all.
many thanks

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

New patch here #2407007-23: Uncaught TypeError when using with Media

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new advagg-2907586-8-hotfix-slicknav.patch2.46 KB

AdvAgg patch that will hotfix the issue. Clear the caches so the new hook gets picked up. Might also need to regen js aggregates.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike at Centarro commented

I tried with both patches for both modules and i got

Fatal error: Cannot redeclare class JavaScriptPacker in /modules_path/advagg/advagg_js_compress/jspacker.inc on line 85

which is about WSOD for the entire site
This is for the latest dev.

For the latest release, i can't use this patch, only the one for other module.
And it's the same as previous. I mean it doesn't work.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

Should be fixed with this #2906290-44: Endless page load on dev server (jquery_update) in MS Edge/IE

  • mikeytown2 committed 09f2e86 on 7.x-2.x 
    Issue #2907586 by mikeytown2: Adminimal Administration Menu breaks...
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Needs review » Fixed
StatusFileSize
new advagg-2907586-11-hotfix-slicknav.patch2.72 KB

This patch has been committed.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike at Centarro commented
Status: Fixed » Needs work

I'm afraid i can't confirm the fix.
I confirm the previous message about jspacker is gone.
But the "theme still broken".
What's new, i can't see the error message in console.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Needs work » Active

Back to the drawing board. Fixing the js error in Adminimal Administration Menu didn't fix your issue.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Active » Postponed (maintainer needs more info)
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

Any update on this?

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike at Centarro commented

@mikeytown2: i'm afraid i gave up on using Adminimal Administration Menu (togheter with advagg).
So i do not have any updates since previous comment.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
nithinkolekar’s picture

nithinkolekar CreditAttribution: nithinkolekar commented
Status: Closed (cannot reproduce) » Fixed
Parent issue: » #2927301: 2 jQuery versions loaded on a singe page and defer is enabled; jQuery.holdReady never gets released with second jquery inclusion if split over multiple files

Committed in parent issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.