This is a follow-up to #1982848: Warn that 'protect all forms' disables caching on certain pages
One of my biggest frustrations with the Honeypot module is that when you enable the module, caching is instantly broken on all pages that have a protected form because the default time limit is set to 5.
I would like to see some more serious messaging when caching has been disabled on these pages. I've been hired to diagnose performance issues on several sites that have been honeypotted because the site architects either missed the current warning, or didn't fully consider the ramifications.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | honeypot-stronger_cache_warning-2907386-4.patch | 576 bytes | chris matthews |
| #2 | honeypot-stronger_cache_warning-2907386-2.patch | 962 bytes | jenlampton |
Comments
Comment #2
jenlamptonComment #3
chris matthews commentedHi Jen, this patch no longer applies on 7.x-1.x-dev.
Comment #4
chris matthews commentedHere is an updated patch against the current 7.x-1.x-dev for review.
Comment #5
chris matthews commentedIt may also be helpful to add an additional drupal_set_message warning if the ''Use Javascript protection for cacheable pages. (experimental)' is checked, but I can't work out how to make this work.
Comment #6
chris matthews commentedComment #7
tr commentedThis seems to be a duplicate of #2415835: On core performance page, warn about honeypot's disabling of page cache. ? Please review the patch in that issue and submit the above patch in that issue if you think that is a better solution.
Regardless, this needs to be addressed in 2.0.x first at this point.
Comment #8
tr commentedComment #9
tr commentedFixed by #2415835: On core performance page, warn about honeypot's disabling of page cache.