POS "Order Item" Widget

Talked to Shawn on DrupalCon Vienna Gonna work on it.

@Shawn I am able to ge the auto complete Field widget with image (For the database search Alpha1 and Alpha2 will be search_api lik we discussed). for the entity_reference field type. Can you please direct me how to include this into the POSForm::
i will give the widget patch tomorrow. Was trying to figure out the POSForm:: Its getting little complicated. Kindly please direct me.

Looks like it is coming from

core.entity_form_display.commerce_order.pos.default.yml Still I am not clear.

Just Uploaded the very rough patch of the work. Will be working tomorrow as well,

TODO: lot of things

1) Correct template to show the searching data(Title, image, price)
2) Add to the current order link
3) Filter with the current store.
4) Search API will be a separate issue. First I will complete with the Database API then search API

Just checking for the test

Things are Done.
1) Auto Complete Widget for field
2) On the Close of Autocomplete. product will be automatically get added to Order / Cart. Sot it will be easy while doing the scanning also

Pending,
1) Theming for the widget
2) Filtering the product from the store.

@shawn please take a look at the patch.

Yup, agree with smccabe's comment above. interdiff attached - this will show up product variations instead of product bundle itself.
Existing error: The Order Item widget has some issues while saving.

Caution: This change may not show product title in the absence of product attributes! so, a repeat of product title for different variations do not seem to be a good idea. Have to think of something better here.

Please review.

When I am trying to apply above patch, I am getting the following error,

git apply -v 2906515-16.patch
Checking patch commerce_pos.libraries.yml...
error: while searching for:
  version: VERSION
  css:
    layout:
      css/commerce_pos.module.css: {}
error: patch failed: commerce_pos.libraries.yml:2
error: commerce_pos.libraries.yml: patch does not apply
Checking patch commerce_pos.routing.yml...
Checking patch js/commerce_pos_widget.js...
Checking patch src/Controller/AutoCompleteAddOrder.php...
Checking patch src/Controller/PosOrderItemAutoComplete.php...
Checking patch src/Form/POSForm.php...
error: while searching for:
      $formatted_amount = $number_formatter->formatCurrency(0, $default_currency);
    }


    $totals[] = ['Subtotal', $formatted_amount];

    // Commerce appears to have a bug where if not adjustments exist, it will return a

error: patch failed: src/Form/POSForm.php:77
error: src/Form/POSForm.php: patch does not apply
Checking patch src/Plugin/Field/FieldWidget/PosOrderItemWidget.php...

patch command gives similar output:

patch -p1 --dry-run < 2906515-16.patch
checking file commerce_pos.libraries.yml
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED
checking file commerce_pos.routing.yml
checking file js/commerce_pos_widget.js
checking file src/Controller/AutoCompleteAddOrder.php
checking file src/Controller/PosOrderItemAutoComplete.php
checking file src/Form/POSForm.php
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] y
Hunk #1 FAILED at 77.
1 out of 1 hunk FAILED
checking file src/Plugin/Field/FieldWidget/PosOrderItemWidget.php

Rerolled the patch to apply to HEAD again. No further changes.

Here's some work-in-progress. The widget is working to add purchasable items as order items to the order. It is using auto-complete and the order form is automatically updating once the order item has been added. I've also added a script that can be run using drush scr that sets up a commerce site for testing this - ie. it creates a store, some products and variations.

Still need to work on:

• Add ability to change quantity, price and remove to order items mentioned above. (again, see POS 7.x)

The theming is going to be using view modes. The current patch allows you to select a view mode for autocomplete product selection and also for how the order items are viewed.

Moved over to just using #ajax for all the processing - so no custom js or routes to update the order form.

Added buttons to increase and decrease quantity but they're not working quite right when you have more than one order item.

Added a javascript test and moved some of the ajax processing around. This is definitely ready for reviews now.

Some code clean up.

Going to investigate why no tests running.

I see... I was adding a fixture to make it easy for people / myself to set up a site for commerce_pos testing. Unfortunately run-tests.sh was not able to work out it is not a test :( - removing the fixture for now.

Here's some coding standards fixes.

1. Re sku into a link - I think this should be a separate followup issue. We're using view modes to control how everything looks so we should add a field formatter for this.
2. Re making the order item unit price editable. That's interesting. I think that that means we need to move the order item list to being a form mode instead of a view mode.
3. I'm not sure I understand what you mean by "show adjustment option".

Going to work on "making the order item unit price editable".

So making the unit price editable and work nicely has been held up by the discovery of #2923388: Add #ajax support to the commerce_price form element

I've moved the order items into a table - this will make it way easier to theme and I've move the quantity into a field. The latter brings up the point that maybe we just want to rely on HTML5 number fields for the + and - buttons since modern browsers will just add them to the number field. Also patch disables the ability to change the unit price because we're waiting on #2923388: Add #ajax support to the commerce_price form element. Tasks to bring this up to the same level as the Drupal 7 version is to handle adjustments and to add the ability to remove an order item with a single click.

I've left all the plumbing in for unit price changing including the tests so some code is commented out in the test but I think that is simpler.

I've added the remove button and the removing the + and - for quantity as I don't think there is any need to maintain this. I've opened #2924956: Handle adjustments on POS form for fixing and testing adjustments.

One question for usability - should we default the minimum quantity to 1 so the only way to remove an order item is to click on the remove button. I think that that might make for better usability. Amazon's order form in the UK works this way but we are dealing with a different level of access to the system here and sometimes for cashiers speed is everything.