Problem/Motivation
Most, or maybe all, of the timestamps in the test fixture, ck2.php, are the same. The time created and time changed for all orders is the same and also for the products. This may be true for nodes and other things with timestamps.
For testing, it would be better to have a different created and changed for each item and more importantly that the timestamps are different for each order, product or whatever.
Also, the revision timestamps need to updated to match the value in the changed timestamp for that item.
Proposed resolution
Review the timestamps in ck2.php to select the ones to change. But include, order, products.
Remaining tasks
Modify timestamps in commerce_order table
Modify timestamps in commerce_producttable
Test
Commit
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comments
Comment #2
karthikkumarbodu commentedModified timestamps in the test fixture
Comment #4
karthikkumarbodu commentedFixed failed test cases.
Comment #6
karthikkumarbodu commentedFixed two failed test cases.
Comment #8
karthikkumarbodu commentedFixed one test case failing
Comment #10
karthikkumarbodu commentedComment #11
quietone commentedAbsolutely spot on! Great.
Just about to RTBC when I realized that the revisions tables need to be changed as well. I believe the revision time stamp should match the value in the changed field for the given item. Updated the IS to include revisions.
@karthikkumarbodu, apologies for forgetting about the revision tables.
Comment #12
karthikkumarbodu commentedUpdated revision_timestamp in revision tables.
Comment #14
heddnFailures are from #2906650: Test failures on HEAD: Drupal\Tests\commerce_migrate_commerce\Kernel\Migrate\d7\OrderTest .
Comment #16
heddn