Problem/Motivation

Most, or maybe all, of the timestamps in the test fixture, ck2.php, are the same. The time created and time changed for all orders is the same and also for the products. This may be true for nodes and other things with timestamps.

For testing, it would be better to have a different created and changed for each item and more importantly that the timestamps are different for each order, product or whatever.

Also, the revision timestamps need to updated to match the value in the changed timestamp for that item.

Proposed resolution

Review the timestamps in ck2.php to select the ones to change. But include, order, products.

Remaining tasks

Modify timestamps in commerce_order table
Modify timestamps in commerce_producttable
Test
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Comments

quietone created an issue. See original summary.

karthikkumarbodu’s picture

Status: Active » Needs review
StatusFileSize
new29.63 KB

Modified timestamps in the test fixture

Status: Needs review » Needs work
karthikkumarbodu’s picture

Status: Needs work » Needs review
StatusFileSize
new32.09 KB

Fixed failed test cases.

Status: Needs review » Needs work
karthikkumarbodu’s picture

Status: Needs work » Needs review
StatusFileSize
new32.3 KB

Fixed two failed test cases.

Status: Needs review » Needs work
karthikkumarbodu’s picture

Status: Needs work » Needs review
StatusFileSize
new32.3 KB

Fixed one test case failing

Status: Needs review » Needs work
karthikkumarbodu’s picture

Status: Needs work » Needs review
StatusFileSize
new32.3 KB
quietone’s picture

Issue summary: View changes
Status: Needs review » Needs work

Absolutely spot on! Great.

Just about to RTBC when I realized that the revisions tables need to be changed as well. I believe the revision time stamp should match the value in the changed field for the given item. Updated the IS to include revisions.

@karthikkumarbodu, apologies for forgetting about the revision tables.

karthikkumarbodu’s picture

Status: Needs work » Needs review
StatusFileSize
new62.57 KB

Updated revision_timestamp in revision tables.

Status: Needs review » Needs work
heddn’s picture

heddn’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.