Problem/Motivation

Convert OrderTest::testOrder to use assertOrder that is in CommerceMigrateTestTrait.

Proposed resolution

  1. Move the method

Remaining tasks

Write the patch
Test
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#11 interdiff-2905484-6-11.txt1.08 KBkarthikkumarbodu
#11 convert_OrderTest_to_use_assertOrder-2905484-11.patch1.74 KBkarthikkumarbodu
#6 convert_OrderTest_to_use_assertOrder-2905484-6.patch1.75 KBkarthikkumarbodu
#4 convert_OrderTest_to_use_assertOrder-2905484-4.patch1.38 KBkarthikkumarbodu
#2 convert_OrderTest_to_use_assertOrder-2905484-2.patch991 byteskarthikkumarbodu

Comments

quietone created an issue. See original summary.

karthikkumarbodu’s picture

karthikkumarbodu commented
Status: Active » Needs review
StatusFileSize
new convert_OrderTest_to_use_assertOrder-2905484-2.patch991 bytes

Status: Needs review » Needs work

The last submitted patch, 2: convert_OrderTest_to_use_assertOrder-2905484-2.patch, failed testing. View results

karthikkumarbodu’s picture

karthikkumarbodu commented
Status: Needs work » Needs review
StatusFileSize
new convert_OrderTest_to_use_assertOrder-2905484-4.patch1.38 KB

Status: Needs review » Needs work

The last submitted patch, 4: convert_OrderTest_to_use_assertOrder-2905484-4.patch, failed testing. View results

karthikkumarbodu’s picture

karthikkumarbodu commented
Status: Needs work » Needs review
StatusFileSize
new convert_OrderTest_to_use_assertOrder-2905484-6.patch1.75 KB

Status: Needs review » Needs work

The last submitted patch, 6: convert_OrderTest_to_use_assertOrder-2905484-6.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: convert_OrderTest_to_use_assertOrder-2905484-6.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Legit failures.

karthikkumarbodu’s picture

karthikkumarbodu commented
Status: Needs work » Needs review
StatusFileSize
new convert_OrderTest_to_use_assertOrder-2905484-11.patch1.74 KB
new interdiff-2905484-6-11.txt1.08 KB

Status: Needs review » Needs work

The last submitted patch, 11: convert_OrderTest_to_use_assertOrder-2905484-11.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)

@karthikkumarbodu, thanks for working on this and tidying up the code. Unfortunately, OrderTest was updated in another patch (haven't looked for which one) and this is now outdated.