Add a per-gateway setting to skip collecting billing information

Thanks, works well.

Show 'Payment information' pane summary on 'Review' step when 'needs_billing' option is disabled.

Add schema for needs_billing.

Thank you for the patch!

If store has only one payment gateway defined, Payment information is shown as empty fieldset once when 'Collect billing information' option is disabled. Any possibility to check and hide fieldset entirely if only one payment gateway defined?

I don't want to keep the patch in RTBC cause it might make someone believe it's safe to use. This is very experimental and will crash any gateway expecting a billing profile.

Does this work with the Commerce Braintree gateway?

We use that for credit cards and PayPal and don't need any address info.

Edit: This doesn't appear to work with the Commerce Braintree payment gateway.

Here is the patch based on #8 and compatible with latest dev and Commerce 8.x-2.5 Release.

Patch #12 works for me.

Anybody have an idea how to offer user to fill billing info if he wants?

I might be missing something obvious in configuration, but it doesn't seem like you can make the billing information optional on the order entity? So I have empty billing info which prevents a save without that data if you edit an order. Like I say, perhaps there's some config I've missed somewhere?

Here is the patch compatible with latest dev and Commerce 8.x-2.10 Release.

Dubs, you are right!

We still have a problem with editing order in administration interface. We should also remove billing information form from there.

I've never faced the problem as I never tried to edit order via web-interface.

Instead of making the billing information optional through checkout pane configuration it could be more usefull to Keep billing information as a separate pane instead of replacing it with the payment information pane.

@mike82 - that sounds like a good idea. A lot of sites would not require billing information at all.

Just updated drupal/commerce (2.11.0 => 2.12.0) and the patch no longer applies.

Rebased patch on #15

Time to revisit this.

We need to make this a payment gateway annotation + setting. Existing gateways might crash without a billing profile, so they need to opt-in.

Here's a rough sketch made after discussing with jsacksick.

Needs an update hook for making the billing_profile field optional.
Needs a functional test somewhere (PaymentCheckoutTest, I guess).

I want to have it optional for user. Could I add it to patch?

Checkbox Collect billing information change to radios:

Collect billing information

• Require billing information
• Optional for user
• Do not collect

@Bobík
No, that would need to stay custom to your site.

In buildPaneForm at PaymentInformation.php:

    if ($this->order->isPaid() || $this->order->getTotalPrice()->isZero()) {
      // No payment is needed if the order is free or has already been paid.
      // In that case, collect just the billing information.
      $pane_form['#title'] = $this->t('Billing information');
      $pane_form = $this->buildBillingProfileForm($pane_form, $form_state);
      return $pane_form;
    }

So it seems there is edge case for free orders - even with current patch it will not be able to disable biling profile form.

Yes, this only covers non-free orders currently.
Free orders have a separate code path, and settings for it are being explored in #2871483: Add checkout settings for payment method behavior. Not sure we should touch it here.

Here are some cleanups.

Simplified the payment gateway setting logic.
Added a warning description after brainstorming with Ryan.

Fixed the following problems:
1) The payment gateway label should be shown in the Review page even if there's no billing information. The test should confirm.
2) PaymentMethodEditForm should create the billing profile if missing, cause it's possible that the merchant enabled billing info collection after it was previously disabled.
3) testManualWithoutBilling should confirm that the payment instructions are still shown, cause that confirms a payment was created as well.

Opened #3050301: Clean up the payment method plugin forms for related cleanups, to avoid bloating this patch.
Opened #3050303: Forward port the 1.x button to explicitly add a profile on the order edit form for the admin UI problem mentioned in #14 / #16.

Added explanation docblocks to the Onsite and OffsiteRedirect example gateways.
Tweaked the docblocks for OrderInterface::getBillingProfile and PaymentMethodInterface::getBillingProfile.

Committed! Change record created. Screenshot attached.

Since the setting is per-gateway, you can easily duplicate your gateway and have two versions, one that collects billing information and one that doesn't. You can then use conditions to restrict each one to specific order types, stores, customer roles, etc. That would give you per-order-type, per-store, per-customer-group settings as well!

Note that only the Manual gateway shows this checkbox right now. Each gateway will need to be updated by adding the requires_billing_information = FALSE annotation key, and updating code to check for a NULL billing profile.

Braintree issue: #3050427: Allow not collecting billing information.
Stripe issue: #3050428: Allow not collecting billing information.

Also note that #9 (the empty fieldset) was fixed in #3049355: Checkout panes are rendered even if they are empty.

Awesome work, thanks! Just encountered with such case.