Comments

leonardop@ciandt.com created an issue. See original summary.

leopaccanaro’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new2.29 KB
joachim’s picture

Status: Needs review » Reviewed & tested by the community

LGTM.

zahor’s picture

StatusFileSize
new11.12 KB

Updated patch for most recent code.

  • Keep README lines within 80 chars.
  • Remove leading \
  • Document method parameter
  • Change variable to camel case (and update all instances)
  • Remove extraneous spaces
  • Fix static variable definition typo

Status: Reviewed & tested by the community » Needs work
zahor’s picture

StatusFileSize
new2.87 KB
zahor’s picture

StatusFileSize
new12.57 KB
zahor’s picture

zahor’s picture

StatusFileSize
new9.43 KB

Updated for testing.

aohrvetpv’s picture

Status: Needs work » Needs review
StatusFileSize
new10.71 KB
new899 bytes

Same as #9 except adds missing newlines to some files, per Coder Drupal standard. For example, fixes:

--- a/password_policy_history/password_policy_history.info.yml
+++ b/password_policy_history/password_policy_history.info.yml
@@ -4,4 +4,4 @@ package: Security
 type: module
 core: 8.x
 dependencies:
-  - password_policy
\ No newline at end of file
+  - password_policy

Thanks, Zahor. The convention for patch file naming is that the comment # follow the issue #, by the way.

Status: Needs review » Needs work
aohrvetpv’s picture

Title: Code Review » Fix Coder Drupal standard violations
Status: Needs work » Needs review
StatusFileSize
new5.02 KB
new4.13 KB

- Made issue title more specific.
- Changed patch to remove changes pertaining to $user_context. The tests pass NULL for $user_context, but it is type-hinted as array, hence the test failure. The fix to this seems less trivial so we can handle it as a separate issue. I think making the $user_context parameter optional may be the best solution, but not sure.

Status: Needs review » Needs work
aohrvetpv’s picture

Status: Needs work » Needs review
StatusFileSize
new5.69 KB
new3.36 KB

Uploaded incorrect patch file in previous comment.

aohrvetpv’s picture

Title: Fix Coder Drupal standard violations » Fix most Coder Drupal standard violations

Clarified issue title.

aohrvetpv’s picture

Going ahead with commit even though not all Coder Drupal standard violations are fixed.

(Doing so because some of these coding standard issues are flagged by the Drupal.org testing infrastructure, and it is distracting when looking through issues. This will clean things up a bit.)

  • AohRveTPV committed 6ac0529 on 8.x-3.x authored by leopaccanaro
    Issue #2904763 by Zahor, AohRveTPV, leopaccanaro: Fix most Coder Drupal...
aohrvetpv’s picture

Status: Needs review » Fixed

Thanks, leopaccanaro and Zahor.

aohrvetpv’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.