- Made issue title more specific.
- Changed patch to remove changes pertaining to $user_context. The tests pass NULL for $user_context, but it is type-hinted as array, hence the test failure. The fix to this seems less trivial so we can handle it as a separate issue. I think making the $user_context parameter optional may be the best solution, but not sure.
Going ahead with commit even though not all Coder Drupal standard violations are fixed.
(Doing so because some of these coding standard issues are flagged by the Drupal.org testing infrastructure, and it is distracting when looking through issues. This will clean things up a bit.)
Comments
Comment #2
leopaccanaro commentedComment #3
joachim commentedLGTM.
Comment #4
zahor commentedUpdated patch for most recent code.
Comment #6
zahor commentedComment #7
zahor commentedComment #8
zahor commentedComment #9
zahor commentedUpdated for testing.
Comment #10
aohrvetpv commentedSame as #9 except adds missing newlines to some files, per Coder Drupal standard. For example, fixes:
Thanks, Zahor. The convention for patch file naming is that the comment # follow the issue #, by the way.
Comment #12
aohrvetpv commented- Made issue title more specific.
- Changed patch to remove changes pertaining to
$user_context. The tests pass NULL for$user_context, but it is type-hinted asarray, hence the test failure. The fix to this seems less trivial so we can handle it as a separate issue. I think making the$user_contextparameter optional may be the best solution, but not sure.Comment #14
aohrvetpv commentedUploaded incorrect patch file in previous comment.
Comment #15
aohrvetpv commentedClarified issue title.
Comment #16
aohrvetpv commentedGoing ahead with commit even though not all Coder Drupal standard violations are fixed.
(Doing so because some of these coding standard issues are flagged by the Drupal.org testing infrastructure, and it is distracting when looking through issues. This will clean things up a bit.)
Comment #18
aohrvetpv commentedThanks, leopaccanaro and Zahor.
Comment #19
aohrvetpv commented