It will be nice to have api.php file for D8.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2904585-4-field_group-api-php.patch | 2.33 KB | sime |
| #2 | 2904585-2-field_group-api-php.patch | 2.15 KB | eric.chenchao |
It will be nice to have api.php file for D8.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2904585-4-field_group-api-php.patch | 2.33 KB | sime |
| #2 | 2904585-2-field_group-api-php.patch | 2.15 KB | eric.chenchao |
Comments
Comment #2
eric.chenchao commentedComment #3
gambryReally minor tweaks. This can be changed on commit or even not changed at all, as issues seem to be consistent with original method definition docblock (see
field_group_pre_render()on field_group.module).So RTBCing. I suggest dockblock changes to be fixed if a followup, so we can fix the .api.php and .module files in one shot.
Thanks!
I understand this is confusing from the
field_group_pre_render()definition, but I would at least add Object as previous parameter just to avoid CS errors."The entity / form beïng rendered" to be "The entity / form being rendered.".
arraytypehint on&elementis missing. To bearray &$element.Comment #4
simeApplied suggestions in #3 with additional linting fixes for good measure.
Comment #5
nils.destoop commentedSeems good. I added an extra hook 'hook_field_group_form_process'
Comment #7
nils.destoop commented