It would be useful if we expose the commerce_promotion_usage table data to views. Although one should be careful that this only contains coupons which are applied. This wont be useful right away , if one requires to show all the coupons applied or not.

CommentFileSizeAuthor
#12 interdiff_9-11.txt3.47 KBjsacksick
#11 2903769-11.patch3.45 KBjsacksick
#9 expose-2903769-9.patch3.7 KBsvendecabooter
#7 expose-2903769-7.patch3.45 KBsorabh.v6
#7 expose-2903769-7-interdiff.txt232 bytessorabh.v6
#4 expose-2903769-4.patch3.45 KBsumanthkumarc
#3 expose-2903769-2.patch2.62 KBsumanthkumarc
#2 expose-2903769-2.patch2.61 KBsumanthkumarc

Comments

sumanthkumarc created an issue. See original summary.

sumanthkumarc’s picture

sumanthkumarc commented
Status: Active » Needs review
StatusFileSize
new expose-2903769-2.patch2.61 KB

For anyone with similar requirements, here's the patch.

sumanthkumarc’s picture

sumanthkumarc commented
StatusFileSize
new expose-2903769-2.patch2.62 KB

Oops, here's the new patch with correct module name.

sumanthkumarc’s picture

sumanthkumarc commented
StatusFileSize
new expose-2903769-4.patch3.45 KB

yet another patch, Last patch i promise :P, which added missing field, filter and argument handlers for fields.

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Assigned: Unassigned » sorabh.v6
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented

Hey @sumanthkumarc,

I tried your patch and I can confirm that it added a new category(commerce promotion usage) to the view of promotion type. That category also has 4 fields as shown below -

Only local images are allowed.

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
StatusFileSize
new expose-2903769-7-interdiff.txt232 bytes
new expose-2903769-7.patch3.45 KB

There was a whitespace at the end of the patch. Removed that white and uploading new one.

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Assigned: sorabh.v6 » Unassigned
svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
StatusFileSize
new expose-2903769-9.patch3.7 KB

Reroll of the latest patch against latest Commerce codebase.

klabautermann_’s picture

klabautermann_ commented

Tested against commerce 8.x-2.33. Solved my usecase to show all used coupons.

jsacksick’s picture

jsacksick commented
StatusFileSize
new 2903769-11.patch3.45 KB

I tested the patch and it works great. However I think the different labels / descriptions should be tweaked. For example, we should rename "Commerce promotion usage" to just "Promotion usage" so that it's after Promotion on the view creation page.

Also, to be consistent with the other relationships, I think we should rename the different labels to "Promotion", "Coupon" instead of "Promotion ID", "Coupon ID" etc...

Patch attached... Thoughts?

jsacksick’s picture

jsacksick commented
StatusFileSize
new interdiff_9-11.txt3.47 KB

Attaching the interdiff.

klabautermann_’s picture

klabautermann_ commented

Just reviewed it and I think the renaming of labels and descriptions is good for readability at least for "mail" and "Promotion usage". Thanks @jsacksick

jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Committed! Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.