Problem/Motivation

The visibility settings of blocks with translations are not migrated. This was discovered while working on #2225681: Migrate D6 i18n blocks translated strings

In #90 of that issue maxocub wrote:
What I understood and what I tried was:
1) Fresh D6 install
2) Enable i18nblocks
3) Add a language, say French
4) Enable path prefix for language selection
5) Go to the Blocks page
6) Configure a block, say Navigation
7) Chose French in the languages selection
8) Now, if you are seeing the site in English, you don't see the Navigation block, but if you see it in French (/fr) you see it.
9) Then if you migrate, on the D8 site the Navigation block is visible on both English and French, which is not the same behavior as on the D6 site.

If on the D8 site I configure the Main Navigation block and select French, then the visibility configuration of the block will be:

visibility:
  language:
    id: language
    langcodes:
      fr: fr
    negate: false
    context_mapping:
      language: '@language.current_language_context:language_interface'

But in the above migration scenario, the visibility configuration of the block is empty.

Proposed resolution

Write a patch.

Remaining tasks

Do it.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#20 migrate-block-language-visibility-settings-2903579-20.patch3.63 KBiwayman
#18 migrate-block-language-visibility-settings-2903579-18.patch3.62 KBfengtan
#17 2903579-nr-bot.txt2.2 KBneeds-review-queue-bot
#16 migrate-block-language-visibility-settings-2903579-16.patch3.61 KBfengtan

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented

Just a comment that phenaproxima said during the Vienna sprint that he recalls in D8 a block either exists or it doesn't so that the visibility settings are interesting.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Issue tags: +migrate-d6-d8

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Related issues: +#3367125: Migrate block content-type visibility settings
fengtan’s picture

fengtan
Location Montreal, Canada
commented
Status: Active » Needs review
StatusFileSize
new migrate-block-language-visibility-settings-2903579-16.patch3.61 KB

Here is a patch that migrates language visibility records.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2903579-nr-bot.txt2.2 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new migrate-block-language-visibility-settings-2903579-18.patch3.62 KB

Fixed indentation.

Status: Needs review » Needs work

The last submitted patch, 18: migrate-block-language-visibility-settings-2903579-18.patch, failed testing. View results

iwayman’s picture

iwayman commented
StatusFileSize
new migrate-block-language-visibility-settings-2903579-20.patch3.63 KB

Use language context_mapping instead of node when migrating language visibility.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Migrate Drupal Module was approved for removal in #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3522602: [meta] Tasks to remove Migrate Drupal module and the removal work in #3522602: [meta] Tasks to remove Migrate Drupal module.

Migrate Drupal will not be moved to a contributed project. It will be removed from core after the Drupal 12.x branch is open.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Postponed » Closed (won't fix)

The Migrate Drupal Module and Migrate Drupal UI are deprecated and they are not in Drupal 12.0.0.

Issues for these modules should now be on the 11.x branch. And the changes are limited to critical and major bug fixes. Other changes are allowed at the discretion of the core Release Managers in consultation with the Migrate subsystem maintainers.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.