Problem/Motivation

The block migration does not seem to support migrating content type visibility settings:

Screenshot of content type visibility settings

Any chance this can be supported?

Steps to reproduce

  1. On a Drupal 7 site, configure a block to show up only on specific content types (see screenshot above)
  2. Migrate the site to Drupal 10 by executing d7_block.yml

Expected result: the block is still configured to show up on specific content types in Drupal 10

Actual result: the visibility criteria are not migrated

Proposed resolution

Attached is a proposed patch that adds support for this.

CommentFileSizeAuthor
#8 migrate-block-node-type-visibility-3367125-8.patch8.11 KBfengtan
#6 migrate-block-node-type-visibility-3367125-6-failpatch.patch3.71 KBfengtan
#3 migrate-block-node-type-visibility-3367125-3.patch4.36 KBfengtan
migrate-block-node-type-visibility.patch3.63 KBfengtan
migrate_block_content_type_visibility.png79.16 KBfengtan

Comments

fengtan created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, migrate-block-node-type-visibility.patch, failed testing. View results

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new migrate-block-node-type-visibility-3367125-3.patch4.36 KB

Updated patch to accommodate automated tests.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a valid simple request.

quietone’s picture

quietone commented
Category: Feature request » Task
Status: Reviewed & tested by the community » Needs work

If this data existing on D7 and is not migrated then it is a task, changing status.

Looking at the comments I see no evidence of a review of this change. Setting back to NR.

However, I looked at the patch. A migration also needs a Kernel migration test and a fail patch. Setting back to NW. Ask in #migration for support on those.

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new migrate-block-node-type-visibility-3367125-6-failpatch.patch3.71 KB

Thanks for the review @quietone -- I reached out to #migration in slack and came up with a failpatch that includes a migration test. Moving to NR to check if it fails...

Status: Needs review » Needs work

The last submitted patch, 6: migrate-block-node-type-visibility-3367125-6-failpatch.patch, failed testing. View results

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new migrate-block-node-type-visibility-3367125-8.patch8.11 KB

Failpatch failed as expected -- now here is the full patch, let's see if it succeeds...

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems to be failing on the 11.x branch.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue tags: +migrate-d6-d8, +migrate-d7-d8
quietone’s picture

quietone commented
Status: Needs work » Postponed

The Migrate Drupal Module was approved for removal in #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3522602: [meta] Tasks to remove Migrate Drupal module and the removal work in #3522602: [meta] Tasks to remove Migrate Drupal module.

Migrate Drupal will not be moved to a contributed project. It will be removed from core after the Drupal 12.x branch is open.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Postponed » Closed (won't fix)

The Migrate Drupal Module and Migrate Drupal UI are deprecated and they are not in Drupal 12.0.0.

Issues for these modules should now be on the 11.x branch. And the changes are limited to critical and major bug fixes. Other changes are allowed at the discretion of the core Release Managers in consultation with the Migrate subsystem maintainers.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.