Add form validations in Cartform and in AddToCartForm [#2903504]

Problem/Motivation

Right now if you add more products than the available it say that the product was added to the cart, but the cart is empty, the same happens when you update the cart.

Proposed resolution

For the CartForm we should add the validation in the EditQuantity class.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#7	2903504-7.commerce.Add-form-validations-in-Cartform-and-in-AddToCartForm.patch	7.27 KB	joachim
#4	add_form_validations_in-2903504-4.patch	3.16 KB	edurenye

Comments

Comment #1

21 August 2017 at 08:12

edurenye created an issue. See original summary.

Comment #2

edurenye commented 21 August 2017 at 08:16

Project:	Commerce Stock	» Commerce Core
Version:	8.x-1.x-dev	» 8.x-2.x-dev
Component:	Code	» Cart

This affects the commerce stock module, but should be fixed in the commerce using the availability manager.

Comment #3

edurenye commented 21 August 2017 at 08:50

Assigned:

Unassigned

» edurenye

Comment #4

edurenye commented 21 August 2017 at 08:52

Status:

Active

» Needs review

Status	File	Size
new	add_form_validations_in-2903504-4.patch	3.16 KB

Done.

Comment #5

drugan commented 21 August 2017 at 17:32

The #4 is worked for me. Great addition!

Comment #6

joachim commented 8 December 2017 at 22:32

Status:

Needs review

» Needs work

A few minor problems:

+++ b/modules/cart/src/Form/AddToCartForm.php
@@ -192,6 +192,24 @@ class AddToCartForm extends ContentEntityForm implements AddToCartFormInterface
+    $availabilityManager = \Drupal::service('commerce.availability_manager');

+++ b/modules/cart/src/Plugin/views/field/EditQuantity.php
@@ -140,6 +141,31 @@ class EditQuantity extends FieldPluginBase {
+    $availabilityManager = \Drupal::service('commerce.availability_manager');

This should be injected.

+++ b/modules/cart/src/Form/AddToCartForm.php
@@ -192,6 +192,24 @@ class AddToCartForm extends ContentEntityForm implements AddToCartFormInterface
+      $form_state->setErrorByName('quantity', t('This amount of purchasable entities are not available.'));

+++ b/modules/cart/src/Plugin/views/field/EditQuantity.php
@@ -140,6 +141,31 @@ class EditQuantity extends FieldPluginBase {
+          $form_state->setErrorByName($this->options['id'], t('This amount of purchasable entities are not available.'));

'This amount' is singular, but 'are not' is plural...

Comment #7

joachim commented 11 December 2017 at 10:43

Status:

Needs work

» Needs review

Status	File	Size
new	2903504-7.commerce.Add-form-validations-in-Cartform-and-in-AddToCartForm.patch	7.27 KB

Fixed the problems in #6, and also changed the message to mention the product variation name, so it's clearer.

Comment #8

drugan commented 11 January 2018 at 07:27

This functionality is now implemented in the Commerce Extended Quantity module:

https://www.drupal.org/project/commerce_xquantity

Thanks to @edurenye and @joachim for the changes made in the EditQuantity.php file. Though in the AddToCartForm.php file I've done this a little differently:

http://cgit.drupalcode.org/commerce_xquantity/tree/src/Form/XquantityAdd...