Mergefields can not be translated: Email Address, First Name, Last Name [#2903123]

Spent 40 minutes on reading discussions about difficulties with translating Mailchimp fields, but yet it doesn't work on Drupal 8.
Well, I also checked out all README files in the module(s) distribution and found absolutely no information about translating, localization or something.

We have a bilingual website: English and Italian. We don't use some i18n module - just core things. And I don't see any possibilities to translate those fields - neither on Form translation nor in User interface translation.

Using 1.3.0 version
Drupal 8.3.7

Comment	File	Size	Author
#4	2903123-4_signupblock-formlabel-translation.patch	534 bytes	ytsurk
#4	8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks
#3	2903123-3_signupblock-formlabel-translation.patch	531 bytes	ytsurk
#3	8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 August 2017 at 12:04

OnkelTem created an issue. See original summary.

Comment #2

OnkelTem CreditAttribution: OnkelTem commented 18 August 2017 at 12:05

Issue summary:

View changes

Comment #3

ytsurk

Switzerland

CreditAttribution: ytsurk commented 10 October 2017 at 11:18

Status:

Active

» Needs review

File	Size
2903123-3_signupblock-formlabel-translation.patch	531 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks

The issue #2667782: How do I translate the subscription block? popped up again.

I don't know what's the purpose of the is_string check, but it makes no sense to translate an @-var ...

Comment #4

ytsurk

Switzerland

CreditAttribution: ytsurk commented 10 October 2017 at 11:26

File	Size
2903123-4_signupblock-formlabel-translation.patch	534 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks

Sorry .. the patch was wrong ..

Comment #5

27 November 2017 at 06:02

ruscoe committed dda064e on 8.x-1.x authored by ytsurk

Issue #2903123 by ytsurk, OnkelTem: Mergefields can not be translated:...

Comment #6

ruscoe CreditAttribution: ruscoe at ThinkShout for Mailchimp commented 27 November 2017 at 06:03

Status:

Needs review

» Fixed

Interesting.

t('@mergevar', array('@mergevar' => $mergevar->name)) has been in the code for years and I suspect it was intended to force $mergevar->name to always be a string.

However, I can't think of a situation where $mergevar->name would be anything other than a string or an empty value (unlikely) and your patch will handle both those situations perfectly well.

Committed. Thanks!