Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Tests
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Aug 2017 at 08:49 UTC
Updated:
10 Sep 2017 at 15:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
drunken monkeyThat's not the actual test fail/error. This merely seems to occur because a test fails, the query is serialized as part of the test data and then, upon unserialization, that error occurs. We already have defensive code in
Query::__wakeup()to prevent this, but it's apparently still not good enough. The attached patch would improve it further. (Not sure, you can probably not test it via Travis like this?)The test fail itself is probably just #2903633: Fix current test fails, which also failed on the d.o test bot. Let's see how the next Travis build looks.
Comment #3
borisson_Test is now green: https://travis-ci.org/mkalkbrenner/search_api_integration_tests/jobs/267... so no need to actually do this do fix the test.
I do like that this is now more defensive! Next time something like this breaks we can be sure that travis breaks in a more expected way, by just failing the test.
Comment #5
drunken monkeyThanks for reviewing!
Yes, I also think it's a good idea to be on the safe side there.
Committed.