form_set_error display name variable instead of the content [#290259]

-Create a nodereference field using autocomplete on a content type.
-Create the content type and in that field type and find a reference and select any one in the dropdown.
-Now in the nid field, change the number and submit so the match errors.
-The message "%name : Title mismatch. Please check your selection." displays.

On line 344, the following should be changed

form_set_error($error_field, t('%name : Title mismatch. Please check your selection.'), array('%name' => t($field['widget']['label'])));

the t() is closed prematurely and I think the second t() is unnecessary as it is an input field and cannot be used to translate and is redundant once the first t() is closed properly. I suggest changing it to

form_set_error($error_field, t('%name : Title mismatch. Please check your selection.', array('%name' => $field['widget']['label'])));

Comments

Comment #1

yched CreditAttribution: yched commented 4 August 2008 at 22:28

Status:

Active

» Fixed

right, fixed in 5.x-1.x. Thx.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 18 August 2008 at 22:32

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Comment #3

Gerald Mengisen CreditAttribution: Gerald Mengisen commented 21 August 2008 at 19:17

Just FYI for anybody who stumbles upon this error message and has no idea what it means (same was the case for me until now):

I've updated the titles of CCK nodes with an SQL script, but wasn't aware that the titles are also stored in the revisions table. Therefore I got the error above every time I used the node reference field and tried to save the updates.

So when you use
UPDATE content_type_save_address sa
JOIN node n
ON n.nid = sa.nid
SET n.title = CONCAT(sa.field_lastname_value,' ',sa.field_firstname_value);

make sure you also use
UPDATE node_revisions nr
JOIN node n
ON n.vid = nr.vid
SET nr.title = n.title
WHERE n.title <> nr.title;

I no longer get the error above.
P.S.: I'm adding this comment to this bug report because it is the only hit I get in Google for this error.