$config is not listed in $coreGlobals in Drupal_Sniffs_NamingConventions_ValidGlobalSniff.

CommentFileSizeAuthor
#2 coder-config-2902536-2.patch720 bytesmfernea

Comments

mfernea created an issue. See original summary.

mfernea’s picture

mfernea commented
Status: Active » Needs review
StatusFileSize
new coder-config-2902536-2.patch720 bytes

Here is the patch.

mfernea’s picture

mfernea commented

Here is the PR on github: https://github.com/pfrenssen/coder/pull/4.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Postponed (maintainer needs more info)

I just grepped the codebase of both Drupal 7 and Drupal 8 for global $config but I didn't find any instances. Drupal 7 uses global $conf and Drupal 8 uses global $config_directories but both of these are already whitelisted.

Which part of the Drupal ecosystem uses global $config?

mfernea’s picture

mfernea commented

I'm not sure where it was used before, now I can only find it in globals.api.php.

mfernea’s picture

mfernea commented
Status: Postponed (maintainer needs more info) » Active
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Fixed

Good point! I merged the PR into 8.x-3.x. Thanks for the contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.