According to Section 508 1194.22i, Frames shall be titled with text that facilitates frame identification and navigation.

So in order to pass the accessibility test, we would want to add a TITLE attribute to the iframe. This is not really a bug of the module especially the code given by Google also doesn't contain the title attribute as well, so I am placing this under Feature Request, but feel free to change.

Reference: https://section508.gov/content/quick-reference-guide#1194.22i

CommentFileSizeAuthor
#16 google_tag-iframe-title-attr-2902160-16.patch662 bytesfabianfiorotto
#15 google_tag-iframe-title-attr-2902160-1-D8.patch702 bytesmr.valters
#13 google_tag-accessibility-2902160-13-D8.patch612 bytesyannisc
#6 google_tag-accessibility-2902160-6-D8.patch751 byteshuiran
#4 google_tag-title_attr-2902160-4-D8.patch733 byteshuiran
#2 google_tag-title_attr-2902160-1-D8.patch656 byteshuiran

Comments

huiran created an issue. See original summary.

huiran’s picture

huiran commented
StatusFileSize
new google_tag-title_attr-2902160-1-D8.patch656 bytes

Patch that adds TITLE attribute to the iFrame.

huiran’s picture

huiran commented
Status: Active » Needs review
huiran’s picture

huiran commented
StatusFileSize
new google_tag-title_attr-2902160-4-D8.patch733 bytes

Also adding aria-hidden="true" per thread https://www.drupal.org/node/2878894 for accessibility.

huiran’s picture

huiran commented
Title: Title attribute for iFrame » iFrame Accessibility
huiran’s picture

huiran commented
StatusFileSize
new google_tag-accessibility-2902160-6-D8.patch751 bytes

Updated patch to pass check on frame content.

lreynaga’s picture

lreynaga commented

+1 for #6

I am able to see the title attribute in the iframe. We follow Section 508 within our accessibility standards, so this is definitely something worth having in the module.

lreynaga’s picture

lreynaga commented
Status: Needs review » Reviewed & tested by the community
klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

+1 yes please.

  • solotandem committed 57ab957 on 8.x-1.x authored by huiran 
    Issue #2902160 by huiran Add title and aria-hidden attribute to noscript...
solotandem’s picture

solotandem commented
Status: Reviewed & tested by the community » Fixed

Thanks for reporting this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yannisc’s picture

yannisc commented
StatusFileSize
new google_tag-accessibility-2902160-13-D8.patch612 bytes

Patch #6 adds content inside the iframe that fails HTML validation.

I attach a patch that removes this content :)

solotandem’s picture

solotandem commented

@yannisc Better late than never, I committed your patch in context of #2946496: <noscript> fails w3c validation. Thanks.

mr.valters’s picture

mr.valters
Location Georgia
commented
StatusFileSize
new google_tag-iframe-title-attr-2902160-1-D8.patch702 bytes
fabianfiorotto’s picture

fabianfiorotto commented
StatusFileSize
new google_tag-iframe-title-attr-2902160-16.patch662 bytes

Rerolled for version 1.6