In #2842222: D7 Plain text fields incorrectly migrated to D8 as Text (formatted), we need to replace the static map in the d7_field migration by a process plugin that will instantiate field plugins and call a method taht will return the field type (This will be dealt with in #2893061: Create a ProcessField plugin to process the field types).
The only field plugins missing to get rid of this static map are EntityReference, ListField, NumberField & PhoneField. Since they are related and quite small, let's do them in one patch.
Add the missing field plugins (EntityReference, ListField, NumberField & PhoneField) and remove the static map.
Write a patch. Review.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-2901851-2-6.txt | 4.06 KB | maxocub |
| #6 | 2901851-6.patch | 3.55 KB | maxocub |
| #2 | 2901851-2.patch | 5.23 KB | maxocub |
Comments
Comment #2
maxocub commentedThe class bodies of the field plugins won't be necessary once we add those methods to the FieldPluginBase (#2896507: Update FieldPluginBase with a default processFieldValues() and getFieldFormatterMap()).
Depending of wich one gets in first, I will re-roll the other.
Comment #3
joelpittet#2843617: Field formatter mappings defined in getFieldFormatterMap have no effect #2447727: Add base class for migrating reference fields
Adding a couple or related issues for entity references.
Comment #4
jofitzSuccessfully adds the plugins required to avoid the workaround applied in the latest patch of #2893061: Create a ProcessField plugin to process the field types.
Patch applied and tested locally - looks good to me.
Comment #5
catchJust committed/pushed #2896507: Update FieldPluginBase with a default processFieldValues() and getFieldFormatterMap() so this could use a re-roll.
Comment #6
maxocub commentedHere's the re-roll.
Comment #7
catchThanks. Also that's such a tidy patch now.
Comment #8
catchCommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!
Comment #11
maxocub commentedComment #12
maxocub commented