Problem/Motivation

In #2842222: D7 Plain text fields incorrectly migrated to D8 as Text (formatted), we need to replace the static map in the d7_field migration by a process plugin that will instantiate field plugins and call a method taht will return the field type (This will be dealt with in #2893061: Create a ProcessField plugin to process the field types).

The only field plugins missing to get rid of this static map are EntityReference, ListField, NumberField & PhoneField. Since they are related and quite small, let's do them in one patch.

Proposed resolution

Add the missing field plugins (EntityReference, ListField, NumberField & PhoneField) and remove the static map.

Remaining tasks

Write a patch. Review.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#6 interdiff-2901851-2-6.txt4.06 KBmaxocub
#6 2901851-6.patch3.55 KBmaxocub
#2 2901851-2.patch5.23 KBmaxocub
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

maxocub created an issue. See original summary.

maxocub’s picture

maxocub CreditAttribution: maxocub commented
Status: Active » Needs review
FileSize
2901851-2.patch5.23 KB

The class bodies of the field plugins won't be necessary once we add those methods to the FieldPluginBase (#2896507: Update FieldPluginBase with a default processFieldValues() and getFieldFormatterMap()).
Depending of wich one gets in first, I will re-roll the other.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Related issues: +#2447727: Add base class for migrating reference fields, +#2843617: Field formatter mappings defined in getFieldFormatterMap have no effect

#2843617: Field formatter mappings defined in getFieldFormatterMap have no effect #2447727: Add base class for migrating reference fields

Adding a couple or related issues for entity references.

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs review » Reviewed & tested by the community

Successfully adds the plugins required to avoid the workaround applied in the latest patch of #2893061: Create a ProcessField plugin to process the field types.

Patch applied and tested locally - looks good to me.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs re-roll

Just committed/pushed #2896507: Update FieldPluginBase with a default processFieldValues() and getFieldFormatterMap() so this could use a re-roll.

maxocub’s picture

maxocub CreditAttribution: maxocub commented
Status: Needs work » Needs review
Issue tags: -Needs re-roll
FileSize
2901851-6.patch3.55 KB
interdiff-2901851-2-6.txt4.06 KB

Here's the re-roll.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Thanks. Also that's such a tidy patch now.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

  • catch committed 8ec06ce on 8.5.x 
    Issue #2901851 by maxocub: Replace the static map in the d7_field...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

maxocub’s picture

maxocub CreditAttribution: maxocub for Acquia commented
maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer and for Acquia commented