Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
There's a lot of code repetition in #2893073: Create a EntityReference Field plugin, #2893075: Create a ListField Field plugin, #2893076: Create a NumberField Field plugin, #2893077: Create a PhoneField Field plugin
Proposed resolution
As mentioned in #2893073-8: Create a EntityReference Field plugin, let's add a default action for processFieldValues() & getFieldFormatterMap().
Remaining tasks
- Write a patch
- Review.
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#16 | interdiff-10-16.txt | 765 bytes | maxocub |
#16 | 2896507-16.patch | 10.07 KB | maxocub |
#10 | 2896507-9.patch | 9.33 KB | heddn |
#9 | interdiff_3-8.txt | 1.53 KB | heddn |
Comments
Comment #2
heddnComment #3
heddnI've also cleaned up implementations of child classes where they were already implementing the empty functionality. No interdiff.
Comment #4
heddnComment #5
maxocub CreditAttribution: maxocub commentedNice work cleaning it up!
Comment #7
heddnFailure in unrelated part of code. Back to rtb.
Comment #9
heddnUpdated patch to fix code standards caught by test bot for unused imports. Back to RTBC and hopes that the unrelated test failures don't cause additional false failures.
Comment #10
heddnOops
Comment #13
heddnStop it.
Comment #15
catchLet's do it, but this needs a change record.
Comment #16
maxocub CreditAttribution: maxocub commentedCreated a change record draft.
Also removed an implementation of getFieldFormatterMap() that got in since the last patch.
My change was trivial, so I take a chance and put it directly back to RTBC.
Comment #17
heddn+1 on rtbc
Comment #18
heddnAlso did another review of the CR. All looks good here.
Comment #20
catchCommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!
Also tagging for release notes.
Comment #22
maxocub CreditAttribution: maxocub for Acquia commentedComment #23
maxocub CreditAttribution: maxocub as a volunteer and for Acquia commented